Bubble up child process errors in IndexCreationTool#6261
Draft
pl4nty wants to merge 1 commit into
Draft
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Signed-off-by: Tom Plant <tom.plant@devicie.com>
florelis
approved these changes
Jun 1, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
IndexCreationTool can run several child processes. If any of them fails, index creation has partially failed and I expect an exception, but IndexCreationTool exits 0. This PR throws an exception with the exit code and command/args to assist with debugging. I also updated
makeappx unpackto use the sharedRunCommandfunction.I suspect IndexCreationTool isn't a stable/supported dependency, but thought this was worth submitting anyway.
🔗 References
Example SignTool error: https://github.com/pl4nty/winget-extras/actions/runs/26671649037/job/78615909376
🔍 Validation
I don't have a VS toolchain on hand, so I'd love if someone can run the ADO tests on this PR. Then I'll validate in my CI from the built IndexCreationTool.
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow