[OpsAI] Fix unhandled KeyError in /user/<username> route -> return 404 - #42
Open
mw-middleware-labs-sandbox[bot] wants to merge 1 commit into
Open
[OpsAI] Fix unhandled KeyError in /user/<username> route -> return 404#42mw-middleware-labs-sandbox[bot] wants to merge 1 commit into
mw-middleware-labs-sandbox[bot] wants to merge 1 commit into
Conversation
…nhandled KeyError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The
GET /user/<username>route inflask/app.py(user_profilefunction) accessed the in-memoryuser_datadict via unguardeduser_data[username]. When the requested username did not exist (e.g.user7), this raised an unhandledKeyError, resulting in an HTTP 500 error instead of a proper client-facing 404.This was confirmed via trace data showing deterministic 500 responses for
/user/user7requests, with the stack trace pointing toapp.pyline 78 inuser_profile.Fix
user_data[username]withuser_data.get(username).None, callabort(404, description=f"User '{username}' not found").abortto the Flask imports.Test Cases
GET /user/user1-> 200 (unchanged behavior for existing users)GET /user/user7-> 404 with descriptive message (previously 500 with unhandled KeyError)OpsAI Context
Open OpsAI Chat: Open Chat
Created By
Name: Sandbox
Email:
sandbox@middleware.io