Skip to content

Structural code simplification#477

Open
aidenybai wants to merge 12 commits into
mainfrom
cursor/structural-code-simplification-d7be
Open

Structural code simplification#477
aidenybai wants to merge 12 commits into
mainfrom
cursor/structural-code-simplification-d7be

Conversation

@aidenybai
Copy link
Copy Markdown
Member

This pull request contains changes generated by a Cursor Cloud Agent

Open in Web Open in Cursor 

cursoragent and others added 11 commits May 25, 2026 07:35
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@reactreview
Copy link
Copy Markdown

reactreview Bot commented May 25, 2026

0 score

Copy as prompt
Check if these React Review issues are valid. If so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.

Run this before and after your changes to verify the result:
npx react-doctor@latest --verbose --diff

Do not modify the react-doctor configuration unless explicitly asked.
Fix the underlying code issues instead of changing or suppressing the rules.

React Review found 0 errors and 1 warning. This PR leaves the React health score unchanged.

<file name="packages/core/src/runners/oxlint/spawn-batches.ts">

<violation number="1" location="packages/core/src/runners/oxlint/spawn-batches.ts:100">
Severity: Warning

await inside a while-loop runs the calls sequentially — for independent operations, collect them and use `await Promise.all(items.map(...))` to run them concurrently

Collect the items and use `await Promise.all(items.map(...))` to run independent operations concurrently

Rule: `async-await-in-loop`
</violation>

</file>

Reviewed by reactreview for commit e6782d9. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 399e233. Configure here.

export const ROLE_SUPPORTS_ARIA_PROPS: Record<
string,
ReadonlySet<string>
> = buildRoleSupportsAriaProps();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ARIA role prop mappings

Medium Severity

The refactor of ROLE_SUPPORTS_ARIA_PROPS inadvertently omitted several roles, including all doc-* roles, graphics-* roles, and none. This causes the role-supports-aria-props rule to skip validation for aria-* attributes on these roles, allowing invalid usage to go unreported. For role="none", this means it no longer flags any aria-* props.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 399e233. Configure here.

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants