Structural code simplification#477
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Copy as promptReviewed by reactreview for commit e6782d9. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 399e233. Configure here.
| export const ROLE_SUPPORTS_ARIA_PROPS: Record< | ||
| string, | ||
| ReadonlySet<string> | ||
| > = buildRoleSupportsAriaProps(); |
There was a problem hiding this comment.
Missing ARIA role prop mappings
Medium Severity
The refactor of ROLE_SUPPORTS_ARIA_PROPS inadvertently omitted several roles, including all doc-* roles, graphics-* roles, and none. This causes the role-supports-aria-props rule to skip validation for aria-* attributes on these roles, allowing invalid usage to go unreported. For role="none", this means it no longer flags any aria-* props.
Reviewed by Cursor Bugbot for commit 399e233. Configure here.
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>


This pull request contains changes generated by a Cursor Cloud Agent