✨ add RAG search API#213
Open
sebastianMindee wants to merge 2 commits into
Open
Conversation
ianardee
requested changes
Jul 23, 2026
Comment on lines
+29
to
+38
| public function __toString(): string | ||
| { | ||
| return implode("\n", array_merge( | ||
| [ | ||
| 'Models', | ||
| '######', | ||
| (string) $this->models, | ||
| ], | ||
| $this->paginationLines() | ||
| )); |
Collaborator
There was a problem hiding this comment.
The logic is flipped, the base method should do the implode, child method should send the array.
Comment on lines
+64
to
+74
| private function parseDate(?string $dateString): ?DateTimeImmutable | ||
| { | ||
| if (empty($dateString)) { | ||
| return null; | ||
| } | ||
| try { | ||
| return new DateTimeImmutable($dateString); | ||
| } catch (Exception) { | ||
| return null; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
this method should be reused across the SDK, look to put it in a date parsing or utility class in the Parsing namespace.
Comment on lines
+181
to
+184
| public function searchModels( | ||
| ModelSearchParameters|string|null $modelName = null, | ||
| ?string $modelType = null | ||
| ): ModelSearchResponse { |
Collaborator
There was a problem hiding this comment.
that is pretty horrible. ask to see if there are better alternatives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: experimental - Claude Opus 4.8-generated
Types of changes