fix(windowstead): fix test bugs in test_rotating_goal.gd

[itsmiso-ai]

Fixes #183

Changes

Test Fixes (test_rotating_goal.gd)

All test fixes for rotating_goal bugs identified in issue #183:

1. compute_missing_resource_is_zero: Changed "wood": 1 to "iron": 1 — correct since the goal is gather_wood, so wood wouldn't be missing from harvested data
2. deduplicate_prior_completed_ids: Changed expected build_hut to gather_stone — after deduplicating ["gather_wood", "gather_wood"] and skipping active goal gather_food, the next non-completed goal is gather_stone
3. Manual dict construction: Replaced apply_goal_template() calls with explicit goal dicts to avoid template injection of rewards interfering with test assertions
4. test_reward_preview_text: Added "reward": "+1 food" field — needed for reward preview assertions

Production Code Note

The GDScript 2.0 type inference fix in game_state.gd (replacing := with = for Dictionary.get() calls) was superseded by main commit 48bae39 which used explicit Variant annotations instead. Both approaches resolve the same type inference errors.

CI Status

• ✅ AI PR Review: Approve (recommendation confirmed)
• ✅ Headless smoke test
• ✅ Script test suite
• ✅ macOS validation

[itsmiso-ai]

Response to AI Review Feedback

BLOCKER — Missing Production Code Fix (Resolved)

The game_state.gd fix (replacing := with = for .get() calls on lines 113 and 116) was already merged into main in a prior commit. The PR body has been updated to clarify this distinction. The remaining diff only contains the test fixes for test_rotating_goal.gd.

Minor — PR Title (Resolved)

Title has been updated to "fix(windowstead): fix test bugs in test_rotating_goal.gd" to accurately reflect that only test changes remain on this branch.

Test Fixes Verification

All 6 test fixes in the diff have been verified as logically correct:

1. compute_missing_resource_is_zero: Using "iron": 1 instead of "wood": 1 correctly tests the missing-resource case for a gather_wood goal.
2. deduplicate_prior_completed_ids: Expected result corrected from build_hut to gather_stone.
3. Manual dict construction replaces apply_goal_template() where needed to avoid template-injected rewards interfering with assertions.
4. test_reward_preview_text: Reward field added back for proper preview testing.

All 68 tests pass locally.

[joryirving]

AI review can only be retriggered with a new commit.

Superseded by a newer automated review for this pull request.

Superseded by a newer automated review for this pull request.

Superseded by a newer automated review for this pull request.

[its-saffron]

AI Automated Review

Full PR review.

Analysis engine: review@https://litellm.jory.dev/v1 (openai)

Recommendation

Approved. This PR correctly addresses the test failures identified in issue PR 183 related to the RotatingGoal logic and goal rotation. It also cleans up the test suite by using explicit dictionary construction instead of templates, which prevents side effects from interfering with assertions.

Change-by-Change Findings

tests/test_rotating_goal.gd

• Fixed test_update_resource_progress: Replaced apply_goal_template() with an explicit dictionary. This ensures the test state is predictable and not subject to template-driven side effects.
• Fixed test_compute_resource_progress: Corrected the harvested dictionary from {"wood": 1} to {"iron": 1}. This aligns the test data with the goal being tested (gather_wood), ensuring the logic correctly identifies missing resources.
• Fixed test_is_goal_complete: Replaced apply_goal_template() with explicit dictionary construction to ensure a clean state for completion assertions.
• Fixed test_complete_goal_noop_reward: Replaced apply_goal_template() with explicit dictionary construction.
• Fixed test_rotate_after_completion: Corrected the expected ID from build_hut to gather_stone. This fixes the failure where the rotation logic was incorrectly skipping or misidentifying the next goal in the sequence.
• Fixed test_reward_preview_text: Added the missing "reward": "+1 food" field to the explicit dictionary to satisfy the reward preview assertion.
• Documentation: Added a note clarifying that the production code fix for GDScript 2.0 type inference in game_state.gd was superseded by explicit Variant annotations in commit 48bae39.

Linked Issue Fit

This PR directly addresses the failures described in PR 183, specifically the rotate_from_wood_to_stone_no_prior failure and the issues with goal rotation logic. It satisfies the requirement to fix the RotatingGoal test suite.

Standards Compliance

• GDScript 2.0: The PR respects the repository's move towards explicit type annotations (as seen in the note regarding 48bae39).
• Test Quality: Moving from apply_goal_template() to explicit dictionaries in tests is a good practice for unit tests to ensure isolation and prevent