[win] Don't build a custom nanosleep() when not needed#1256
Open
dimula73 wants to merge 3 commits into
Open
Conversation
This reverts commit 64aa543.
Instead of relying of the includes order we should properly check if the function is actually provided by our version of pthread library.
Contributor
Author
|
There is still an unorthodox usage of Though I'm not sure if such a change is acceptable or not |
It seems like there is some issue with that with MSYS2: msys2/MINGW-packages#10459
Member
It used to exist even if not in a standard. Google search on it first hit leads me to; Since it is unorthodox it is OK to change it IMO. |
ddennedy
approved these changes
Jun 10, 2026
Member
|
I approve the change but wait to see what you do about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying of the includes order we should properly
check if the function is actually provided by our version
of pthread library.
The patch basically reverts an original hack to resolve the
issue in msys2 and implements a proper detection mechanism
for the presence of nanosleep() in the pthread library