src/modules/core/transition_mix.c: Increase MAX_CHANNELS to 32#995
src/modules/core/transition_mix.c: Increase MAX_CHANNELS to 32#995Tjoppen wants to merge 1 commit into
Conversation
This matches filter_audiomap.c
|
Did you consider an approach to change this service to remove the static definition and dynamically allocate and loop based on the number of actual channels? I wonder how hard that would be to do. |
|
It probably wouldn't be too hard to do. This is quick and doesn't hurt. |
|
Oh and to address your comment in the other PR, this one has been tested and is known to work with filter_audiomap.c. Perhaps rather than doing what #996 does, a common API for reporting channel limits could be introduced? That way there's a way to query it. |
It increases memory usage on projects with multiple mix transitions. Using my example from the other PR, the project with 100 mix transitions needs 2.3 GiB RAM just for the mix transitions. Do your requirements permit a lower value such 8 - 16? |
3 participants
This matches filter_audiomap.c
Perhaps this should be a project-wide CMake option? Conform them for now.