Skip to content

Stabilize task cancellation cleanup test #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lntutor wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Stabilize task cancellation cleanup test #1712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/ModelContextProtocol.Tests/Server/TaskCancellationIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ public async Task TaskTool_CancellationToken_GetTaskShowsWorkingBeforeCancel()

// Cleanup
await client.CancelTaskAsync(taskId, ct);
await _toolCancellationFired.Task.WaitAsync(TestConstants.DefaultTimeout, ct);

@PranavSenthilnathan PranavSenthilnathan Jul 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other tests wait for this condition to assert that a client cancel makes its way into the server tool call and the cancellation is actually observed. This test is not validating that so it's not needed.

The correct cleanup should actually be handled by the server during disposal. This is a separate issue tracked in #1707.

}
}

Expand Down