Skip to content

fix(time): expand LOCAL_TIMEZONE in Docker ENTRYPOINT #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ks72 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(time): expand LOCAL_TIMEZONE in Docker ENTRYPOINT #4620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/time/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,10 @@ ENV PATH="/app/.venv/bin:$PATH"
# Set the LOCAL_TIMEZONE environment variable
ENV LOCAL_TIMEZONE=${LOCAL_TIMEZONE:-"UTC"}

# Exec-form ENTRYPOINT does not invoke a shell, so "${LOCAL_TIMEZONE}" below was
# never expanded — it was passed to the process as the literal string
# "${LOCAL_TIMEZONE}", which ZoneInfo() then rejected on every run.
# Shell form expands the variable; `exec` still replaces the shell so signals
# (e.g. SIGTERM) reach mcp-server-time directly, same as exec form would.
# when running the container, add --local-timezone and a bind mount to the host's db file
ENTRYPOINT ["mcp-server-time", "--local-timezone", "${LOCAL_TIMEZONE}"]
ENTRYPOINT exec mcp-server-time --local-timezone "$LOCAL_TIMEZONE"