feat: web progress bar#423
Open
NikitaKrinkin wants to merge 1 commit into
Open
Conversation
|
|
Artanias
reviewed
Jul 11, 2026
| test_runs_count: int = 1, | ||
| config: dict[str, Any] | None = None, | ||
| ) -> None: | ||
| from imgtests.suites.map import ALL_SUITES # noqa: PLC0415 |
Collaborator
There was a problem hiding this comment.
Лучше по возможности вообще не делать так импорты без крайней необходимости, а если таким образом попытка избежать циклических импортов -> скорее всего требуется провести рефакторинг кода или поместить логику в другой модуль.
Artanias
reviewed
Jul 11, 2026
| with Path.open(PROG_LOG_PATH, encoding="utf-8") as file: | ||
| data = json.load(file) | ||
| return JsonResponse(data) | ||
| except json.decoder.JSONDecodeError: |
Collaborator
There was a problem hiding this comment.
Тут скорее 238 и 239 строки нужно обернуть, 240 уже не вернёт такую ошибку.
Artanias
reviewed
Jul 11, 2026
| progress_file = Path(PROG_LOG_PATH) | ||
| if progress_file.exists(): | ||
| try: | ||
| with Path.open(PROG_LOG_PATH, encoding="utf-8") as file: |
Collaborator
There was a problem hiding this comment.
А если параллельно запускать это всё, то не будет ли гонки при записи в один и тот же файл и потом как отличить где какой запуск?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#408