Skip to content

Define ONLY_DOCKER for all matrix entries#62

Open
amanbh321 wants to merge 1 commit into
mosip:developfrom
amanbh321:patch-1
Open

Define ONLY_DOCKER for all matrix entries#62
amanbh321 wants to merge 1 commit into
mosip:developfrom
amanbh321:patch-1

Conversation

@amanbh321

@amanbh321 amanbh321 commented Jun 22, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to ensure consistent Docker build settings across all services.

Signed-off-by: amanbh321 <Aman.Bahuguna@iiitb.ac.in>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ab756001-933f-409b-b9e3-8b89fbfc051c

📥 Commits

Reviewing files that changed from the base of the PR and between b97b7b2 and b895ac3.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml

Walkthrough

The push-trigger workflow's Docker build job matrix is updated to add ONLY_DOCKER: true to the certmanager entry. Previously, only databreachdetector carried this flag; certmanager did not.

Changes

CI Matrix Fix

Layer / File(s) Summary
certmanager ONLY_DOCKER matrix flag
.github/workflows/push-trigger.yml
Adds ONLY_DOCKER: true to the certmanager build matrix entry to match the existing databreachdetector configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny flag was missing, oh dear,
certmanager felt left out, a lone frontier.
Now ONLY_DOCKER: true is set just right,
Both services march in docker's delight! 🐇🐳

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Define ONLY_DOCKER for all matrix entries' accurately describes the main change—adding ONLY_DOCKER configuration to all matrix entries in the workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant