Bug 2006684 - add builddecisionscript#1412
Conversation
cd74711 to
3e75319
Compare
a5a19fb to
cbecacb
Compare
47b9491 to
25f35d3
Compare
|
This depends on mozilla-releng/scriptworker#798 to get temporary tc credentials with the task's scopes. |
016d35f to
d35e8a4
Compare
Copy the build-decision code from fxci-config as-is, at revision 6b1ea576b59f8436b28778d5ef2bdd09c80ec348, before adapting it to run as a scriptworker task.
Port the build-decision code to run as a scriptworker task. - rename the project from build-decision to builddecisionscript - adapt the original env-var and cmdline based input to be passed through the scriptworker task payload instead - add the usual scriptworker boilerplate
We'll have a single worker pool here so override the default scriptworker worker type/group/id.
We can use taskgraph directly, no need to keep a copy of these functions.
… (bug 2006684) There's no proxy in scriptworker, we talk to tc directly. Use the credentials fd passed by scriptworker for all taskcluster operations (fetching secrets, triggering hooks, creating tasks).
d35e8a4 to
8b82445
Compare
bhearsum
left a comment
There was a problem hiding this comment.
For the builddecision code itself, I mostly reviewed by comparing fxci-config's version to this, which looked sane.
Unlike other scriptworkers, we skip chain of trust verification.
This is presumably because there's nothing upstream to verify?
(This also makes me wonder: should CoT be verifying any aspect of build decision? I've always found it a bit weird that decision tasks and build-decision tasks don't have a formal link...)
Indeed.
I don't think so? We rebuild the decision task's definition based on the repo contents, and there's not necessarily a build-decision task (particularly for github), so we can't really go past that. |
Port the build-decision code to run as a scriptworker task.
The following changes have been made:
taskgraph.util.keyed_byinstead of a local copyUnlike other scriptworkers, we skip chain of trust verification.