Serve system projects to translate endpoints - #4408
Open
mathjazz wants to merge 1 commit into
Open
Conversation
The History, Comments, Locales and Sibling strings endpoints looked the entity up in `Project.objects.visible()`, which is `available().filter(system_project=False)`. The tutorial is a system project, so all four returned 404 for every user, and the panels showed nothing rather than reporting a failure. What these endpoints need to know is whether the user can reach the project, not whether it is listed on the dashboards. `available()` still excludes disabled and resource-less projects, and `visible_for` still hides private ones from non-superusers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4354.
The History, Comments, Locales and Sibling strings endpoints looked the entity up in
Project.objects.visible(), which isavailable().filter(system_project=False). The tutorial is a system project, so all four returned 404 for every user, and the panels showed nothing rather than reporting a failure.What these endpoints need to know is whether the user can reach the project, not whether it is listed on the dashboards.
available()still excludes disabled and resource-less projects, andvisible_forstill hides private ones from non-superusers.