404 when resource path in the URL path doesn't exist - #4409
Open
mathjazz wants to merge 1 commit into
Open
Conversation
The translate view validated the locale, the project and the ProjectLocale, but took the resource straight from the URL. A path that the locale has no resource for rendered the view with the path in the navigation and an empty string list, which reads as an empty resource rather than as a wrong URL. Require the path to name a resource the locale has a TranslatedResource for, unless it is `all-resources` — the same set the paths menu offers. A resource that is obsolete is a 404 too, and so is one belonging to a locale still waiting for its first sync, which has nothing to translate..
ayshushus
reviewed
Aug 14, 2026
Contributor
There was a problem hiding this comment.
LGTM!!
This doesn't 404 http://localhost:8000/ab/all-projects/foo-i-made-up/also-random.ftl/
because we expect all-projects/all-resources in the slug (and the other case changes the is a different URL anyway) but just curious if that edge case is something we'd want to consider since this is a URL PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4353.
The translate view validated the locale, the project and the ProjectLocale, but took the resource straight from the URL. A path that the locale has no resource for rendered the view with the path in the navigation and an empty string list, which reads as an empty resource rather than as a wrong URL.
Require the path to name a resource the locale has a TranslatedResource for, unless it is
all-resources— the same set the paths menu offers. A resource that is obsolete is a 404 too, and so is one belonging to a locale still waiting for its first sync, which has nothing to translate..