Move the 100% match indicator into the editor menu - #4413
Open
mathjazz wants to merge 1 commit into
Open
Conversation
The indicator pushed the menu down by its own height on every string that had a perfect match, and let it back up on every string that didn't. Moving between such strings made the menu jump, which mozilla#4410 made worse by removing the confirmation dialog that used to slow that movement down. Show it next to the translation length instead.
flodolo
approved these changes
Aug 15, 2026
| expect(indicator).not.toBeNull(); | ||
| expect(indicator.textContent).toContain('100%'); | ||
| // The badge is too small for the whole sentence, so it goes in the tooltip | ||
| expect(indicator.getAttribute('title')).toBe( |
Collaborator
There was a problem hiding this comment.
This seems too specific of a test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4411.
The indicator pushed the menu down by its own height on every string that had a perfect match, and let it back up on every string that didn't. Moving between such strings made the menu jump, which #4410 made worse by removing the confirmation dialog that used to slow that movement down.
Show it next to the translation length instead.
Available on DEV:
https://pontoon.allizom.org/sl/pontoon-test-2/all-resources/?list=322412,322413,322414,322415,322416&string=322412