[draft] Replace vdp/uri with PHP native Uri\Rfc3986\Uri - #162
Draft
peter17 wants to merge 1 commit into
Draft
Conversation
peter17
marked this pull request as draft
August 6, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for your information, feel free to ignore it or use it for a future release:
I have been working on a version of
php-spiderthat does not depend onvdp/uribut instead uses the nativeUri\Rfc3986\Uriof PHP >= 8.5Of course, this breaks for any version < 8.5 which is fine in my use case but certainly not for most users.
It may be useful in the future, however.
I am currently testing it.I've been testing it for a few days and it works fine.I will be maintaining it on a 2.x branch on my fork.
Best regards