-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate Kyper AttentionFilled Icon to MXUI #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mwclemy
wants to merge
18
commits into
master
Choose a base branch
from
cmwimo/CT-2388
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dfe6168
removed TooSmallDialog component
c01512a
updated AttentionFilled to Icon
7aacc87
removed the typing
5ecbd0f
feat: migrate kyper AttentionFilled Icon to MXUI
db6f4d4
Fix formatting issues in README props table
mwclemy 47458e5
Fix markdown formatting in Props table
mwclemy 9c878d3
addressed comments
e76757a
fix more styles
7604b8b
fix config error
b45af19
fix selectionbox
f2e725c
addressed comments
2b14a8e
address comments according to the direction discussed
c4f702f
clean up some kyper token values
0f6f6cf
fixed more styles
a9729bc
using spacing from Stack
6e338b0
moved --mui-spacing to styles.css
9e8ae72
addressed more opportunities to use a Stack for spacing
094fe01
fix accountinfo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .container:global(.MuiStack-root) { | ||
| margin-top: var(--spacing-4-point-5); | ||
| text-align: center; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| .toggleButtonGroup:global(.MuiToggleButtonGroup-root) { | ||
| align-items: center; | ||
| border-radius: 4px; | ||
| display: flex; | ||
| justify-content: center; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .boundLabels:global(.MuiStack-root) { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .textQuestion:global(.MuiStack-root) { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .errorMessage:global(.MuiStack-root) { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .errorMessageText:global(.MuiTypography-root) { | ||
| font-size: 12px; | ||
| } | ||
|
|
||
| .toggleButton:global(.MuiToggleButton-root) { | ||
| align-items: center; | ||
| color: var(--mui-palette-primary-main); | ||
| display: flex; | ||
| flex: 1 0 0; | ||
| font-weight: 600; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a ton of customization going on here. @platypus801 can we use the raw ToggleButtonGroup? |
||
| height: 48px; | ||
| justify-content: center; | ||
| padding: var(--spacing-1-point-5); | ||
| } | ||
|
|
||
| .toggleButton:global(.MuiToggleButton-root.Mui-selected) { | ||
| background-color: var(--mui-palette-primary-main); | ||
| box-shadow: none; | ||
| color: var(--mui-palette-primary-contrastText); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@platypus801 it looks like we're using custom text here. Is there a typography variant that fits here without needing to customize it?