Give the Function build an explicit examples root, and build it in CI - #21
Merged
Conversation
The v0.1.4 release failed after the tag: the Function package build passes no --examples-root, and that flag is not optional -- it defaults to ./examples. So the build collected examples/lab/topology.yaml, helm values with no `kind`, which had landed there in #19, and rejected it. --ignore would not have helped; it does not reach --examples-root. Naming examples/fabric explicitly makes both packages ship the same thing, and says what that thing is: Fabric XRs. examples/lab is scaffolding for running a lab, not a demonstration of the API. CI could not have caught this. It built the Configuration package, which names a narrower examples root, so the two builds disagreed about what "the examples" are -- and the Function package's build existed only in the release, where a failure costs a tag. It now runs on PRs too, without embedding the runtime image, since that is irrelevant to whether the package and its examples parse. Released as v0.1.5 rather than retrying v0.1.4: configuration-avd:v0.1.4 was published before the function leg failed, and moving a tag that has already put an artifact on a registry is how a version number starts meaning two things. v0.1.4 is not broken for consumers -- configuration-avd depends on the function by range, so it resolves to v0.1.3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The
v0.1.4release failed after the tag, on the Function package build:That build passes no
--examples-root, and the flag is not optional — it defaults to./examples. So it collectedexamples/lab/topology.yaml, the helm values file added in #19, which has nokind.--ignoreis no help: it does not reach--examples-root.Why CI did not catch it
CI built the Configuration package, which names
--examples-root=examples/fabric. The Function package build existed only in the release workflow — and with a different (defaulted) examples root. The two builds disagreed about what "the examples" are, and only the one that never ran on a PR saw the new file.So this PR does two things:
examples/fabricexplicitly in the Function build, so both packages ship the same thing and say what it is — Fabric XRs, not lab scaffolding;package/and the examples parse. Same principle as the existingruntime imagejob: do not let a failure be reachable only from the release.Why v0.1.5 and not a retry of v0.1.4
configuration-avd:v0.1.4was published before the function leg failed. Moving a tag that has already put an artifact on a registry is how one version number starts meaning two things.v0.1.4 is not broken for consumers:
configuration-avddepends on the function by range (>=v0.1.2), so it resolves tofunction-avd:v0.1.3. It is an incomplete release, not a failed one.Both builds verified locally with the exact CI invocations.
🤖 Generated with Claude Code