Handle special keys only when IME is not compositing#3189
Conversation
This fixes interference between special keys (ESC, Enter, ...) for Chinese input methods and the UI. Closes nextcloud#2572 Signed-off-by: Chih-Hsuan Yen <645432-yan12125@users.noreply.gitlab.com>
yan12125
force-pushed
the
ime-key-handling
branch
from
480ef62 to
7e551d2
Compare
|
Fine with me, though I cannot test whether it fixes the composition issue. |
Signed-off-by: Raimund Schlüßler <raimund.schluessler+github@mailbox.org>
Refactor compositionstart and compositionend methods to remove event parameters. Signed-off-by: Raimund Schlüßler <raimund.schluessler+github@mailbox.org>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
This fixes interference between special keys (ESC, Enter, ...) for Chinese input methods and the UI.
Closes #2572
I drafted this change long time ago (in 2024, roughly before submitting #2572). I don't remember exact reasons to change keyup to keydown. I just remember keyup doesn't work with compositing detection.
🤖 AI (if applicable)