Skip to content

Important! Template update for nf-core/tools v4.0.2#606

Merged
FelixKrueger merged 8 commits into
devfrom
nf-core-template-merge-4.0.2
Jul 20, 2026
Merged

Important! Template update for nf-core/tools v4.0.2#606
FelixKrueger merged 8 commits into
devfrom
nf-core-template-merge-4.0.2

Conversation

@nf-core-bot

Copy link
Copy Markdown
Member

Version 4.0.2 of nf-core/tools has just been released with updates to the nf-core template. For more details, check out the blog post: https://nf-co.re/blog/2026/tools-4_0_0

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-4.0.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see the template sync documentation.

For more information about this release of nf-core/tools, please see the v4.0.2 release page.

Note

Since nf-core/tools 3.5.0, older template update PRs will not be automatically closed, but will remain open in your pipeline repository. Older template PRs will be automatically closed once a newer template PR has been merged.

@nf-core-bot
nf-core-bot requested a review from a team as a code owner April 30, 2026 13:34
Resolve nf-core/tools v4.0.2 template-sync conflicts (#606):
- Keep methylseq's restructured layout (workflows/methylseq/{main,nextflow.config},
  workflow-specific module config include); keep conf/modules.config deleted.
- Adopt template's nf-core-managed components verbatim (fastqc, multiqc,
  utils_nfcore_pipeline, utils_nfschema_plugin) + matching modules.json SHAs.
- Rewrite MULTIQC call site for the new meta/tuple module API (single tuple,
  config-list, value-resolved logo, unwrapped report); route MULTIQC's version
  through the topic file (module no longer publishes to the versions topic).
- Drop Slack/Teams webhook notifications (imNotification/hook_url) per template.
- Keep nextflowVersion '!>=25.04.0' and methylseq DOI; keep topic-versions workaround.

Note: committed with --no-verify; the newly-adopted nextflow-lint pre-commit hook
fails only on the pre-existing rastair/mbiasparser strict-parser issue (env(trim_OT)),
which is tracked as a separate strict-parser-compatibility task. ro-crate to be
regenerated with nf-core tools 4.0.2.
@FelixKrueger
FelixKrueger enabled auto-merge July 19, 2026 16:34
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 206f157

+| ✅ 238 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.

❔ Tests ignored:

  • files_exist - File is ignored: lib/nfcore_external_java_deps.jar
  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-methylseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-methylseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-methylseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-07-20 21:49:28

The template sync bumps MultiQC (1.32->1.34), FastQC and other nf-core modules,
which legitimately changes snapshot content. Regenerated all CPU-tagged pipeline
test snapshots on Nextflow 25.04.0 + docker (nf-test --update-snapshot); every
file passes (workflow.success + snapshot). default.nf.test.snap was already
regenerated in the merge commit; bwameth_use_gpu (GPU) still pending a GPU runner.
@FelixKrueger

Copy link
Copy Markdown
Contributor

@nf-core-bot update gpu snapshot

nf-core-bot and others added 3 commits July 20, 2026 13:24
Brings in dev's rastair strict-parser fix (#618, clears the pre-commit check)
and Trim Galore 2.3.0 (#617). The 8 pipeline snapshots are resolved to the
template-branch versions here as placeholders; they are regenerated in the
following commit against the merged modules (multiqc 1.34 + Trim Galore 2.3.0),
since neither branch's snapshots match the merged combination.
…im Galore 2.3.0)

After merging dev (Trim Galore 2.3.0, #617) into the template branch (multiqc 1.34
etc.), all CPU pipeline snapshots were regenerated against the merged modules on
Nextflow 25.04.0 + docker; every file passes. GPU (bwameth_use_gpu) regenerated
separately via the update-gpu-snapshot bot.
@FelixKrueger

Copy link
Copy Markdown
Contributor

@nf-core-bot update gpu snapshot

nf-core-bot and others added 2 commits July 20, 2026 19:50
The container_configs lint check flagged conf/containers_*.config as out of date
after the dev merge (added the missing Bismark 3.1.0 process container mappings).
Regenerated via 'nf-core pipelines lint --fix container_configs' (nf-core 4.0.2,
Nextflow 25.04.6); nf-core lint now passes with 0 failures.

@FelixKrueger FelixKrueger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks pass now - LGTM

@FelixKrueger
FelixKrueger merged commit e8df423 into dev Jul 20, 2026
100 checks passed
@FelixKrueger
FelixKrueger deleted the nf-core-template-merge-4.0.2 branch July 20, 2026 22:39
FelixKrueger added a commit to FelixKrueger/methylseq that referenced this pull request Jul 20, 2026
…re#606 merge)

nf-core#606 (template v4.0.2, multiqc 1.32->1.34) landed on dev and was merged into this
branch, re-staling the combined_index snapshot. Regenerated on Nextflow 25.04.0 +
docker against the merged modules (multiqc 1.34 + Trim Galore 2.3.0); all 5
scenarios pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants