feat: use dynamic config to supply custom beta feedback banner#912
feat: use dynamic config to supply custom beta feedback banner#912bmuenzenmeyer wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview That remote config is defined in Reviewed by Cursor Bugbot for commit 3503466. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
- Coverage 86.17% 86.14% -0.04%
==========================================
Files 188 189 +1
Lines 17146 17152 +6
Branches 1540 1540
==========================================
Hits 14776 14776
- Misses 2363 2369 +6
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 1.28 s | 1.30 s | +20.00 ms (+1.56%) |
| User CPU time | 2.75 s | 2.80 s | +50.00 ms (+1.82%) |
| System CPU time | 340.00 ms | 230.00 ms | -110.00 ms (-32.35%) |
| Peak resident memory | 348.51 MB | 343.66 MB | -4.85 MB (-1.39%) |
legacy-html Generator
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 12.46 s | 20.00 s | +7.54 s (+60.51%) |
| User CPU time | 39.93 s | 64.14 s | +24.21 s (+60.63%) |
| System CPU time | 1.60 s | 2.48 s | +880.00 ms (+55.00%) |
| Peak resident memory | 2.33 GB | 2.23 GB | -93.02 MB (-3.91%) |
legacy-json Generator
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 10.23 s | 8.83 s | -1.40 s (-13.69%) |
| User CPU time | 27.83 s | 26.31 s | -1.52 s (-5.46%) |
| System CPU time | 2.06 s | 1.84 s | -220.00 ms (-10.68%) |
| Peak resident memory | 1.69 GB | 1.65 GB | -43.46 MB (-2.51%) |
llms-txt Generator
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 7.74 s | 8.38 s | +640.00 ms (+8.27%) |
| User CPU time | 23.79 s | 25.63 s | +1.84 s (+7.73%) |
| System CPU time | 1.32 s | 2.00 s | +680.00 ms (+51.52%) |
| Peak resident memory | 1.57 GB | 1.67 GB | +102.18 MB (+6.36%) |
orama-db Generator
Output size
| File | Base | Head | Diff |
|-|-|-|-|
| orama-db.json | 8.90 MB | 8.89 MB | -1.33 KB (-0.01%) |
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 8.38 s | 9.35 s | +970.00 ms (+11.58%) |
| User CPU time | 23.44 s | 26.01 s | +2.57 s (+10.96%) |
| System CPU time | 1.44 s | 1.94 s | +500.00 ms (+34.72%) |
| Peak resident memory | 1.59 GB | 1.71 GB | +116.12 MB (+7.12%) |
web Generator
Output size
| File | Base | Head | Diff |
|-|-|-|-|
| all.html | 21.27 MB | 21.27 MB | -158.00 B (-0.00%) |
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 77.88 s | 76.74 s | -1.14 s (-1.46%) |
| User CPU time | 161.49 s | 164.13 s | +2.64 s (+1.63%) |
| System CPU time | 4.90 s | 5.14 s | +240.00 ms (+4.90%) |
| Peak resident memory | 5.59 GB | 5.62 GB | +33.77 MB (+0.59%) |
|
I'd really like if this preview stuff was all in its own directory, so we can remove it when we are done with it |
|
btw are the new diff comments too detailed? |
on top of being broken markdown tables, perhaps edit: otherwise, they are fine. we are used to verbose PR output |
|
I'll improve them :-) |
addressed via 3503466 |
Description
Feedback within nodejs/nodejs.org#8998 (comment) suggested that the beta docs themselves could have a feedback mechanism. To my knowledge, we can do this (once merged to
main)Validation
Upon merge - we should get a custom banner at https://beta.docs.nodejs.org
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.