refactor(v8): cache new V8 version during major update#1116
Merged
Conversation
After updating the V8 tree, we currently re-fetch the new V8 version from the filesystem several times during various tasks. Instead, we can cache it in the same way that we do the existing version. Updates `getCurrentV8Version()` to a generic task that accepts a label for the version, either 'current' or 'new', from which the context property name is derived.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
==========================================
+ Coverage 62.37% 63.06% +0.68%
==========================================
Files 48 50 +2
Lines 7892 8288 +396
==========================================
+ Hits 4923 5227 +304
- Misses 2969 3061 +92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating the V8 tree, we currently re-fetch the new V8 version from the filesystem several times during various tasks. Instead, we can cache it in the same way that we do the existing version.
Updates
getCurrentV8Version()to a generic task that accepts a label for the version, either 'current' or 'new', from which the context property name is derived.