dns: address compile-time warnings#64355
Merged
Merged
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64355 +/- ##
==========================================
- Coverage 90.25% 90.24% -0.02%
==========================================
Files 741 741
Lines 240990 241113 +123
Branches 45402 45441 +39
==========================================
+ Hits 217502 217587 +85
- Misses 15066 15067 +1
- Partials 8422 8459 +37
🚀 New features to boost your workflow:
|
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
anonrig
approved these changes
Jul 8, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
approved these changes
Jul 8, 2026
aduh95
added
the
commit-queue
cjihrig
approved these changes
Jul 9, 2026
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64355 ✔ Done loading data for nodejs/node/pull/64355 ----------------------------------- PR info ------------------------------------ Title dns: address compile-time warnings (#64355) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:dns-c-ares-warnings -> nodejs:main Labels c++, cares, author ready, needs-ci Commits 2 - dns: address compile-time warnings - squash! format-cpp Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64355 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64355 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 08 Jul 2026 10:49:29 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/64355#pullrequestreview-4655080157 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64355#pullrequestreview-4657048517 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/64355#pullrequestreview-4663743030 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-07-08T17:40:03Z: https://ci.nodejs.org/job/node-test-pull-request/74673/ - Querying data for job/node-test-pull-request/74673/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 64355 From https://github.com/nodejs/node * branch refs/pull/64355/merge -> FETCH_HEAD ✔ Fetched commits as 4140d4c2c8ed..71e5a4bf7579 -------------------------------------------------------------------------------- [main 5615ca05ff] dns: address compile-time warnings Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Wed Jul 8 12:38:11 2026 +0200 1 file changed, 350 insertions(+), 223 deletions(-) [main 56e2d0c7ce] squash! format-cpp Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Wed Jul 8 14:47:32 2026 +0200 1 file changed, 17 insertions(+), 24 deletions(-) ✔ Patches applied Please run the following commands to complete landinghttps://github.com/nodejs/node/actions/runs/29089975276 |
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 116302d |
Contributor
|
Hi, it looks like this PR might have broken the test-internet pipeline (which only runs if certain files have been changed, but I only say that because this PR and the failure both relate to DNS, and this was merged between the last successful run and the first unsuccessful run of the pipeline. This PR also makes several references to The new error is: The failing test was added in #960, and is checking behaviour when reading TXT DNS entries for a domain which doesn't have any. |
Contributor
|
I did some experiments with the state before this PR and found:
The new code returns The easiest way to check this for yourself is to run: const dns = require('node:dns/promises');
await dns.resolveTxt('www.microsoft.com');In the currently released versions of Node.js, it returns It seems reasonable that these two behaviours should be made consistent, but it is still a user-facing change which perhaps needs to be considered semver major? (ping @aduh95 @jasnell @anonrig @cjihrig) I have created #64624 to codify these behaviours in the tests (and fix the current failing test by updating it to match the new behaviour), and ensure they run if this file is changed in the future. |
aduh95
added a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #64355 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
added
dont-land-on-v22.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2 remaining warnings are
ares_set_servers/ares_set_servers_portsinsetServers(), which IIUC would require a breaking change to address.N.B.: this is mostly vibe-coded