Skip to content

fixes bugs from building with libc++#64539

Open
mccakit wants to merge 1 commit into
nodejs:mainfrom
mccakit:libcxx_fixes
Open

fixes bugs from building with libc++#64539
mccakit wants to merge 1 commit into
nodejs:mainfrom
mccakit:libcxx_fixes

Conversation

@mccakit

@mccakit mccakit commented Jul 16, 2026

Copy link
Copy Markdown

This PR fixes libc++ compilation errors caused my changes in libc++ that prevent transitive header includes.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg
  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 16, 2026
@Renegade334

Copy link
Copy Markdown
Member

Is there a reason why this isn't being submitted upstream?

@mccakit

mccakit commented Jul 16, 2026

Copy link
Copy Markdown
Author

Is there a reason why this isn't being submitted upstream?

I'm a not a regular contributor here, please direct me what to do

@Renegade334

Copy link
Copy Markdown
Member

The LIEF dependency is vendored from https://github.com/lief-project/LIEF, compilation issues related to the library itself should be submitted there. The vendored dependencies in deps get automatically updated.

@akoeplinger

akoeplinger commented Jul 22, 2026

Copy link
Copy Markdown

I recently hit this as well when compiling node against recent libc++ after llvm/llvm-project#195509

I needed two more fixes besides the changes in your PR:

  • src/tracing/traced_value.cc - uses std::fpclassify but doesn't include <cmath>
  • deps/v8/src/wasm/pgo.h - uses std::atomic<uint32_t> but doesn't include <atomic>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants