module: expose configureTypeScript()#64556
Open
Rishikmanche wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64556 +/- ##
=======================================
Coverage 90.24% 90.25%
=======================================
Files 739 739
Lines 241698 241774 +76
Branches 45556 45558 +2
=======================================
+ Hits 218129 218210 +81
- Misses 15103 15106 +3
+ Partials 8466 8458 -8
🚀 New features to boost your workflow:
|
Signed-off-by: Rishikmanche <rishikmanche@gmail.com>
Rishikmanche
force-pushed
the
fix/issue-64518-configure-typescript
branch
from
July 18, 2026 18:08
8662c0d to
9f90dfe
Compare
Member
|
I'm not sure this is a good idea. I think it would make it harder to release breaking changes in Amaro, and it would complicate configuring Node itself because now there's a runtime way to configure this subsystem in addition to the CLI flags and config file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #64518 by exposing the full Amaro loader API via
node:module.Specifically:
module.configureTypeScript()throughnode:modulemode: 'transform'inmodule.stripTypeScriptTypes()kTransformedTypeScriptandkTransformedTypeScriptWithSourceMapsisUnderNodeModulescheck whennodeModulesis enabled in configurationextensionFormatMap