Skip to content

test: resolve flaky repl test#64594

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:resolve-repl-flaky
Closed

test: resolve flaky repl test#64594
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:resolve-repl-flaky

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Post 4f844f4 (#64034), there's a small chance that test/parallel/test-repl-user-error-handler.js will fail, since it treats our now asynchronous REPL as synchronous.

Based on the in-progress https://ci.nodejs.org/job/node-stress-single-test/800/, the flake rate is <1.5% (1 failure in 70 runs).

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 19, 2026
@avivkeller avivkeller added flaky-test Issues and PRs related to the tests with unstable failures on the CI. repl Issues and PRs related to the REPL subsystem. labels Jul 19, 2026
@avivkeller
avivkeller marked this pull request as draft July 19, 2026 06:43
@avivkeller

Copy link
Copy Markdown
Member Author

Actually, this looks like a bug in V8's replMode: true

@avivkeller avivkeller closed this Jul 19, 2026
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (4f844f4) to head (1bf0e6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64594   +/-   ##
=======================================
  Coverage   90.13%   90.14%           
=======================================
  Files         741      741           
  Lines      241976   241976           
  Branches    45543    45551    +8     
=======================================
+ Hits       218116   218126   +10     
+ Misses      15379    15367   -12     
- Partials     8481     8483    +2     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants