zlib: validate pledgedSrcSize for sync zstd#64601
Open
Archkon wants to merge 2 commits into
Open
Conversation
nodejs-github-bot
added
c++
Archkon
force-pushed
the
zlib2
branch
2 times, most recently
from
July 19, 2026 15:17
56b199b to
ef6ad04
Compare
jasnell
approved these changes
Jul 19, 2026
Contributor
Author
|
It seems thta github action check failed due to flaky test,could some collaborator rerun this ? Thanks ! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64601 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01%
==========================================
Files 741 741
Lines 242076 242093 +17
Branches 45558 45555 -3
==========================================
+ Hits 218216 218230 +14
+ Misses 15385 15356 -29
- Partials 8475 8507 +32
🚀 New features to boost your workflow:
|
Zstd replaces a configured pledged source size with the input size when the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed input in Node and report ZSTD_error_srcSize_wrong when the completed frame does not match the original pledge. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Archkon
force-pushed
the
zlib2
branch
2 times, most recently
from
July 20, 2026 13:58
95703df to
aa63d44
Compare
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
Author
|
@lpinca I don't know what is wrong with jenkins ci tests so could you take a look at these failed test ?Should I resolve these problems ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64600