inspector: fix out-of-bounds read in ws frame decoding#64618
Open
Nashit-h wants to merge 1 commit into
Open
Conversation
Signed-off-by: nashit hayyat <nashit@bugqore.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
requested changes
Jul 21, 2026
| reinterpret_cast<uv_handle_t*>(&client_socket))); | ||
| } | ||
|
|
||
| TEST_F(InspectorSocketTest, WaitsForFrameBodyToArrive) { |
Member
There was a problem hiding this comment.
The test also passed on the main branch without the patch.
Comment on lines
+366
to
+367
| if (remaining < kMaskingKeyWidthInBytes || | ||
| remaining - kMaskingKeyWidthInBytes < payload_length) |
Member
There was a problem hiding this comment.
This reads to me equivalent to this one liner:
Suggested change
| if (remaining < kMaskingKeyWidthInBytes || | |
| remaining - kMaskingKeyWidthInBytes < payload_length) | |
| if (remaining < kMaskingKeyWidthInBytes + payload_length) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode_frame_hybi17 checks the announced payload length against buffer.size(), but the payload is read from it + kMaskingKeyWidthInBytes, after the iterator has already walked past the two byte header and the extended length field. A client that sends only the two header bytes of a masked frame, 0x81 0xFD, underflows buffer.size() - kMaskingKeyWidthInBytes to SIZE_MAX, passes the check, and the unmasking loop reads 125 bytes past a two byte vector; the bytes it picks up go to OnWsFrame and back out to the peer. Measuring against what is left after the header fixes both that underflow and the header bytes the old check never accounted for.