ffi: fix optimized buffer conversions#64639
Open
trivikr wants to merge 1 commit into
Open
Conversation
Preserve pointer-like argument conversions for buffer and arraybuffer signatures after Fast API optimization. Keep memory-backed arguments on the specialized native fast path. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
ShogunPanda
approved these changes
Jul 21, 2026
trivikr
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64639 +/- ##
==========================================
- Coverage 90.13% 90.13% -0.01%
==========================================
Files 741 741
Lines 242076 242057 -19
Branches 45550 45559 +9
==========================================
- Hits 218199 218168 -31
- Misses 15391 15392 +1
- Partials 8486 8497 +11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64638
Fast FFI calls with
bufferorarraybufferargument signatures accepted pointer-like values through the generic path, but rejected non-memory-backed values after optimization.This change keeps the primary optimized entry point compatible with raw pointer conversions while retaining the specialized native fast path for memory-backed arguments. Optimized calls now consistently accept documented representations including
bigint, strings, nullish values, buffers, typed arrays, andArrayBufferobjects.Assisted-by: openai:gpt-5.6-sol