url: handle unparsable serialized URLs in setters#64651
Open
mcollina wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
url-handle-unparsable-href-updates
branch
from
July 21, 2026 13:19
0fee8e8 to
985563f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64651 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 741 741
Lines 242106 242107 +1
Branches 45551 45552 +1
==========================================
+ Hits 218211 218278 +67
+ Misses 15430 15355 -75
- Partials 8465 8474 +9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL updates reparse the stored serialized URL. Return failure when that parse does not succeed so property setters leave the URL unchanged.
Add coverage for URL values that are accepted initially but whose serialized form cannot be parsed again.