test_runner: support directory arguments to --test#64659
Open
dhruvvv0913 wants to merge 1 commit into
Open
Conversation
Since test file discovery moved to the internal glob, a directory passed to `--test` (for example `node --test test/`) matched the directory itself and was then spawned as a test file, failing with MODULE_NOT_FOUND. Directory arguments were documented and supported before that change. Expand a user-supplied pattern that contains no glob magic and resolves to an existing directory into a recursive search for the default test file patterns within it, restoring the previous behavior. Glob patterns and explicit file arguments are unchanged, and `node_modules` remains excluded. Fixes: nodejs#64555 Signed-off-by: dhruv <dhruvtripathi2k5@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
dhruvvv0913
marked this pull request as ready for review
July 21, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since test file discovery moved to the internal glob, a directory passed to
--test(for examplenode --test test/) matched the directory itself and was then spawned as a test file, failing with MODULE_NOT_FOUND. Directory arguments were documented and supported before that change.Expand a user-supplied pattern that contains no glob magic and resolves to an existing directory into a recursive search for the default test file patterns within it, restoring the previous behavior. Glob patterns and explicit file arguments are unchanged, and
node_modulesremains excluded.Fixes: #64555