Skip to content

src: implement MemoryRetainer protocol for ByteSource#64660

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:bytesource-memory-retainer-protocol
Open

src: implement MemoryRetainer protocol for ByteSource#64660
panva wants to merge 1 commit into
nodejs:mainfrom
panva:bytesource-memory-retainer-protocol

Conversation

@panva

@panva panva commented Jul 21, 2026

Copy link
Copy Markdown
Member

cc @addaleax, one of your self-proposed TODOs

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from addaleax July 21, 2026 18:18
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.32990% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (db3a8d8) to head (83df2b9).

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 0.00% 11 Missing ⚠️
src/crypto/crypto_argon2.cc 14.28% 6 Missing ⚠️
src/crypto/crypto_hash.cc 28.57% 5 Missing ⚠️
src/crypto/crypto_hkdf.cc 16.66% 5 Missing ⚠️
src/crypto/crypto_kem.cc 75.00% 3 Missing ⚠️
src/crypto/crypto_kmac.cc 25.00% 3 Missing ⚠️
src/crypto/crypto_sig.cc 25.00% 3 Missing ⚠️
src/crypto/crypto_turboshake.cc 40.00% 3 Missing ⚠️
src/crypto/crypto_aes.cc 33.33% 2 Missing ⚠️
src/crypto/crypto_chacha20_poly1305.cc 33.33% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64660      +/-   ##
==========================================
+ Coverage   90.14%   90.15%   +0.01%     
==========================================
  Files         741      741              
  Lines      242133   242079      -54     
  Branches    45568    45552      -16     
==========================================
- Hits       218265   218258       -7     
+ Misses      15371    15325      -46     
+ Partials     8497     8496       -1     
Files with missing lines Coverage Δ
src/crypto/crypto_aes.h 33.33% <ø> (ø)
src/crypto/crypto_argon2.h 50.00% <ø> (ø)
src/crypto/crypto_chacha20_poly1305.h 33.33% <ø> (ø)
src/crypto/crypto_hash.h 25.00% <ø> (ø)
src/crypto/crypto_hkdf.h 33.33% <ø> (ø)
src/crypto/crypto_hmac.h 20.00% <ø> (ø)
src/crypto/crypto_kem.h 25.00% <ø> (ø)
src/crypto/crypto_kmac.h 33.33% <ø> (ø)
src/crypto/crypto_pbkdf2.h 100.00% <ø> (ø)
src/crypto/crypto_rsa.h 54.54% <ø> (-3.79%) ⬇️
... and 22 more

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants