2026-08-05, Version 26.7.0 (Current) - #65027
Open
github-actions[bot] wants to merge 152 commits into
Open
Conversation
Cut several sources of per-stream/per-request overhead on the hot path: - Track 'priority'/'frameError' stream listeners by overriding the EventEmitter methods on Http2Stream instead of subscribing to 'newListener'/'removeListener', which made every listener add and remove on every stream emit an extra tracking event. - Replace the per-call SafeSet and sensitive-header mapping in buildNgHeaderString with a lazily allocated array and an empty-array fast path, and skip the HTTP token regex and connection-specific header checks for well-known single-value header names. - Replace per-call closures with shared named handlers in onStreamClose, afterShutdown and Http2Stream._destroy. - Skip the pendingStreams Set add/delete for streams that are created with their native handle already available (all server streams). - Hoist the per-request onStreamTimeout closure factories in the compat layer to module-level handlers, and avoid a once() wrapper allocation per server stream. h2load, 1 KiB response payload, -c 4 -m 100, mean of 6 alternating runs: core API 60.2k -> 69.3k req/s (+15%), compat API 43.6k -> 46.2k req/s (+5.9%). Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64265 Backport-PR-URL: #64663 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Every _write()/_writev() on an Http2Stream allocated four closures and an anonymous nextTick callback to coordinate the write callback with the end-of-stream check. Since the stream machinery dispatches at most one write at a time, that coordination state can live on the stream's kState object instead, with shared named functions for the end check and completion logic. When trailers are pending the writable side cannot be shut down early anyway, so the end-of-stream check tick is now skipped entirely for those writes. Also pre-initialize the kState fields that used to be added dynamically (shutdownWritableCalled, fd) so hot-path stores no longer transition the object shape. h2load, 1 KiB response payload, -c 4 -m 100, mean of 6 alternating runs vs main: core API 61.0k -> 70.7k req/s (+15.9% cumulative), compat API 43.7k -> 50.4k req/s (+15.3% cumulative). Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64265 Backport-PR-URL: #64663 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
respond() copied the user-provided options object on every call just so it could normalize and locally flip options.endStream, and prepareResponseHeadersObject() then looked the :status and date fields up again on the dictionary-mode null-prototype headers copy it had just built. Use a local variable for endStream and pick up :status/date while copying the headers instead. No measurable throughput change on its own; this removes an object clone and several dictionary-mode property lookups per response. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64265 Backport-PR-URL: #64663 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Every string-named JavaScript channel consumed an entry in the fixed native subscriber array. Creating more than 1,024 channels triggered a CHECK and terminated the process. Allocate slots only for native publishers and grow the aliased buffer when it fills. Refresh the JavaScript view after resizing and preserve the capacity in snapshots. Signed-off-by: Stephen Belanger <admin@stephenbelanger.com> PR-URL: #64497 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Validate narrow integer and 64-bit BigInt arguments before entering the Fast API trampoline. This prevents out-of-range values from being silently truncated or wrapped and matches the generic FFI path. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol PR-URL: #64614 Fixes: #64613 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Normalize bool to kUint8 when creating Fast API metadata. This keeps optimized calls consistent with generic FFI behavior, including numeric return values and rejection of JavaScript Boolean values. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol PR-URL: #64527 Fixes: #64526 Reviewed-By: Paolo Insogna <paolo@cowtech.it>
When sqlite3_exec() or sqlite3changeset_apply() call JavaScript callbacks (user-defined functions, conflict handlers, or filter callbacks), the DatabaseSync object could be garbage-collected if the JavaScript code drops all references to it. Both methods only held a raw DatabaseSync* pointer on the C++ stack, which V8 GC does not track. Add a BaseObjectPtr<DatabaseSync> guard that keeps the database alive for the duration of these SQLite API calls, preventing a use-after-free when the JavaScript callback triggers GC. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64535 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Cache temporary string conversion buffers by wrapper and active call depth. This prevents nested FFI calls from overwriting or replacing buffers still in use by an outer native call. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol PR-URL: #64551 Fixes: #64550 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
`http.request({ highWaterMark })` passes the value to the TCP socket
via createConnection() but does not set it on the OutgoingMessage
internal kHighWaterMark. OutgoingMessage._writeRaw() has two mutually
exclusive write paths:
Path A (socket connected): conn.write() — uses socket HWM ✓
Path B (no socket yet): outputSize < this[kHighWaterMark] — uses
OutgoingMessage own default (64 KB) ✗
Because the OutgoingMessage constructor already accepts
options.highWaterMark, the fix is to set kHighWaterMark from the
user options after they are parsed in the ClientRequest constructor.
This resolves two symptoms:
1. write() returning the wrong boolean for pre-socket writes (the
user highWaterMark was silently ignored on all Node versions).
2. A deadlock on Node >= 24.16.0 where the incorrect false return
sets kNeedDrain, but drain never fires because the socket was
never backpressured (introduced by the stricter drain gate in
#62936).
Signed-off-by: Naman Trivedi <trivenay@amazon.com>
Fixes: #64645
Refs: #62936
PR-URL: #64653
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pledgedSrcSize represents an exact byte count. Reject values that are not non-negative safe integers instead of silently ignoring or coercing them through IntegerValue(). Apply the same validation to zlib/iter and retain a native validation check for internal callers. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64604 Fixes: #64603 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Jan Martin <jan.krems@gmail.com>
PR-URL: #63918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
And other minor cleanups Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #64668 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Original commit message:
[loong64][compiler] Extend Word64Select instruction functionality
Change-Id: Iba762777642d2d2d3aa904f9afc1e9005139992e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7801520
Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Commit-Queue: Liu Yu <liuyu@loongson.cn>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Liu Yu <liuyu@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#107619}
Refs: v8/v8@c4d06ba
Co-authored-by: liujiahui <liujiahui@loongson.cn>
PR-URL: #63731
Fixes: #63721
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Speed up Interface construction: - Hoist the history accessor property descriptors to module scope and define them with a single ObjectDefineProperties call, instead of allocating six closures and four descriptor objects per instance. - Stop assigning the history options onto the input stream. This avoids hidden class transitions on the user provided stream and no longer mutates it observably. - Only check process.env.TERM for a dumb terminal when the interface is in terminal mode. Reading process.env goes through the environment interceptor and is comparatively expensive, and _ttyWrite is never called when terminal is false. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64585 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Signed-off-by: Guy Bedford <guybedford@gmail.com> PR-URL: #64399 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
A Debugger.paused event can arrive before the response to the resume request that triggered it. The resulting probe evaluation replaces the resume request in `inFlight`, but the resume cleanup then clears the newer request's state. Only clear `inFlight` when it still refers to the request being completed. This preserves probe attribution when the target exits during evaluation. Clarify the existing end-to-end test coverage for this case. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol PR-URL: #64467 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-debugger-probe-failure-process-exit Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> PR-URL: #63175 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
Signed-off-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> PR-URL: #64505 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
StringBytes::StorageSize had a CHECK that fatal-asserted when a hex-encoded string with an odd number of characters was written through Writev (e.g. via HTTP requests which are automatically corked). Writing the same string via a single Write did not crash because StringBytes::Write delegates to HexDecode, which silently drops the trailing incomplete nibble. Remove the CHECK and let integer division handle odd lengths, which is consistent with StringBytes::Size and HexDecode. Fixes: #45150 Signed-off-by: RajeshKumar11 <kakumanurajeshkumar@gmail.com> PR-URL: #63658 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.36.2 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) --- updated-dependencies: - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64927 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps the eslint group in /tools/eslint with 4 updates: [@eslint/markdown](https://github.com/eslint/markdown), [eslint](https://github.com/eslint/eslint), [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) and [globals](https://github.com/sindresorhus/globals). Updates `@eslint/markdown` from 8.0.2 to 8.0.3 - [Release notes](https://github.com/eslint/markdown/releases) - [Changelog](https://github.com/eslint/markdown/blob/main/CHANGELOG.md) - [Commits](eslint/markdown@v8.0.2...v8.0.3) Updates `eslint` from 10.5.0 to 10.8.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.5.0...v10.8.0) Updates `eslint-plugin-jsdoc` from 63.0.9 to 63.3.1 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v63.0.9...v63.3.1) Updates `globals` from 17.7.0 to 17.8.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v17.7.0...v17.8.0) --- updated-dependencies: - dependency-name: "@eslint/markdown" dependency-version: 8.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint-plugin-jsdoc dependency-version: 63.3.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: globals dependency-version: 17.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64928 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 31.10.6 to 31.11.0. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Changelog](https://github.com/cachix/install-nix-action/blob/master/RELEASE.md) - [Commits](cachix/install-nix-action@8aa0397...630ae54) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-version: 31.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64929 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [Mozilla-Actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.10 to 0.0.11. - [Release notes](https://github.com/mozilla-actions/sccache-action/releases) - [Commits](Mozilla-Actions/sccache-action@9e7fa8a...fc920bf) --- updated-dependencies: - dependency-name: Mozilla-Actions/sccache-action dependency-version: 0.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64930 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [github/codeql-action/init](https://github.com/github/codeql-action) from 4.36.2 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64931 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.3.0 to 7.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@ece7cb0...5fda3b9) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64932 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [github/codeql-action/autobuild](https://github.com/github/codeql-action) from 4.36.2 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) --- updated-dependencies: - dependency-name: github/codeql-action/autobuild dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64933 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.36.2 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) --- updated-dependencies: - dependency-name: github/codeql-action/analyze dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64934 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Bumps [actions/stale](https://github.com/actions/stale) from 10.3.0 to 11.0.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@eb5cf3a...4391f3d) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 11.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #64935 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
DatabaseSync::DeleteSessions() deleted native sqlite3_session handles without clearing the pointers held by their Session wrappers. Reopening the database allowed stale session handles to be used, crashing the process. Track Session wrappers and delete sessions through Session::Delete() so the wrappers are marked closed. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #64783 Fixes: #64782 Reviewed-By: Aviv Keller <me@aviv.sh>
PR-URL: #64939 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
PR-URL: #64940 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #64941 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #64942 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #64945 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`TestOptions` as provided to `node:test`'s `test`/`it` supports both
`name` and `fn` as options per its implementation.
I'd like to formalize this as part of the public, documented API.
### Motivation
I have a use-case for consuming both fields. I'd like to be able to
return the result of a function to `test`/`it` without needing to spread
the parameters; e.g.:
```js
const testOptionsFactory = (opts = {}) => {
return {
fn: () => { /* .. */ },
name: opts.name
};
};
test(testOptionsFactory({name: 'foo'}));
```
If I cannot rely on this behavior, then I would need to instead return
an array of parameters and spread them:
```js
const testParamsFactory = (opts = {}) => {
return opts.name !== undefined
? [opts.name, () => { /* .. */ }] : [() => { /* .. */ }];
};
test(...testParamsFactory({name: 'foo'}));
```
I don't think it's too terribly controversial that the former is more
ergonomic than the latter.
### Next Steps
Once this lands, I plan to propose the addition of these fields to
`@types/node`. Since the fields are not currently publicly documented, I
can't justify such a change.
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
PR-URL: #64946
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Pass the stream-wide signal reason directly to writer.fail() so valid non-Error abort reasons are not replaced with an AbortError. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #64798 Fixes: #64797 Reviewed-By: Aviv Keller <me@aviv.sh>
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #64710 Reviewed-By: James M Snell <jasnell@gmail.com>
Only emit 'finish' and set writableFinished once all data has actually been flushed successfully. end() callbacks now report the outcome like stream.Writable: called with null on finish, or with the error that prevented the flush. Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #64847 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Rawal27 <obviouslykamal@gmail.com> PR-URL: #64952 Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #64943 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64944 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64883 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
readableStreamPipeTo allocated, for every chunk written to the
destination, a { promise, resolve, reject } write request record that
it immediately marked as handled, and drove its loop with an async
step()/run() pair whose implicit promises cost one allocation and one
reaction per iteration. The parked-read path additionally allocated a
read request object, a PromiseWithResolvers record, and a microtask
closure per chunk; this is the steady state for pipeThrough, since a
TransformStream's readable side has a high water mark of zero.
Replace the per-write records with a single per-pipe tracker that the
write request queue holds once per pending write and whose
resolve()/reject() methods maintain a pending-write count, drive the
pump loop with plain callbacks instead of async functions, and reuse
one read request and one forwarding function across all chunks, the
same pattern tee uses since c543cfb.
Benchmark results (benchmark/compare.js --runs 20):
webstreams/pipe-to.js +29.9% to +35.8% across all 16 configurations
(all 99.9% confidence); a pipeThrough(TransformStream) passthrough
loop improves ~17%; every other webstreams benchmark is unchanged.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64890
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Signed-off-by: Rawal27 <obviouslykamal@gmail.com> PR-URL: #64957 Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Rich Trott <rtrott@gmail.com>
Notable changes: crypto: * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949 * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746 lib: * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565 module: * (SEMVER-MINOR) implement `Symbol.dispose` in ModuleHooks (Remco Haszing) #63928 test_runner: * (SEMVER-MINOR) add support for `--test-coverage-include-all` (avivkeller) #64830 PR-URL: #65027
aduh95
force-pushed
the
v26.7.0-proposal
branch
from
August 5, 2026 09:18
6ed9d89 to
b4f23d3
Compare
Collaborator
Contributor
Author
Changelog@@ -680,0 +681 @@
+/nix/store/w83dnbrd7w2cvp8pvz5agf228dpkifxg-libtasn1-4.21.0 (aarch64-darwin)
@@ -681,0 +683 @@
+/nix/store/mwk2dssjyq3491nxpwizxnjf41cyjx4q-libtasn1-4.21.0 (x86_64-darwin)
@@ -1006,0 +1009,4 @@
+/nix/store/407rcl1ig0bk39cnk4hfflz2d7mr99dd-node-pkcs11-softhsm (aarch64-darwin)
+/nix/store/4d4lx7dllq1hss55la64lv4bfxlnc42x-node-pkcs11-softhsm (aarch64-linux)
+/nix/store/457f6kv5bgidlmsd0ggf41ggmqi89n6f-node-pkcs11-softhsm (x86_64-darwin)
+/nix/store/97jwl9hn3v9v7zpp033j3lcga7l31p38-node-pkcs11-softhsm (x86_64-linux)
@@ -1162,0 +1169,5 @@
+/nix/store/kcmiw9pa978fxafx91zwaz00cqlp1xsx-openssl-pkcs11.cnf (aarch64-darwin)
+/nix/store/dgjvcxm092jg9vsgfgf6m2i4mv9jln3c-openssl-pkcs11.cnf (aarch64-linux)
+/nix/store/8d925514nm15fw85li0zz0p7xrvj2gdp-openssl-pkcs11.cnf (x86_64-darwin)
+/nix/store/smzplbiai84y5fwgm55s00wh13p24f53-openssl-pkcs11.cnf (x86_64-linux)
+/nix/store/s2ljy8yv2qq563cybsmh5im8bjj0k8w6-p11-kit-0.26.2 (aarch64-darwin)
@@ -1163,0 +1175 @@
+/nix/store/sf6izqsd0wmgp81f1v8rqlfjd9dgz9lg-p11-kit-0.26.2 (x86_64-darwin)
@@ -1342,0 +1355,4 @@
+/nix/store/jhz3vfw8xz0rsmmzrq9i9w7fnvqhk1va-pkcs11-provider-1.2.0 (aarch64-darwin)
+/nix/store/9gwms4rd38922mz4rmn6ifc881381rdc-pkcs11-provider-1.2.0 (aarch64-linux)
+/nix/store/d28w0csy6w0x63bb0xd25rdy1qm0gf72-pkcs11-provider-1.2.0 (x86_64-darwin)
+/nix/store/aqvj16b1lbc8n35shw1yrcna97g2wk7n-pkcs11-provider-1.2.0 (x86_64-linux)
@@ -1516,0 +1533,4 @@
+/nix/store/v1yij4ymgqg86z3n5za11hwsgwamsqmh-softhsm-2.7.0 (aarch64-darwin)
+/nix/store/y9si5nxih0hiv339ab8aj2l04yqhxyzs-softhsm-2.7.0 (aarch64-linux)
+/nix/store/z0gbwg8b52nh3cb2bhfpckrw8d1pq5n6-softhsm-2.7.0 (x86_64-darwin)
+/nix/store/k0qxy12sj3vqissm8xqfgg82zi1rgi78-softhsm-2.7.0 (x86_64-linux) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
82712652cb] - (SEMVER-MINOR) crypto: support loading private keys through STORE loaders (Filip Skokan) #63949b3aec47d09] - crypto: update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746c1e4f7365e] - (SEMVER-MINOR) lib: add perfetto support (Chengzhong Wu) #6456511c2f9c642] - (SEMVER-MINOR) module: implementSymbol.disposeinModuleHooks(Remco Haszing) #63928[removed as it should be treated as semver-majorb6e7935aca] - (SEMVER-MINOR) net: add experimentalnode:net/promisesAPI (Ethan Arrowood) #63965dccee04558] - (SEMVER-MINOR) test_runner: add support for--test-coverage-include-all(avivkeller) #64830Commits
6168067ee0] - async_hooks: use validateBoolean for trackPromises (Soul Lee) #647316eb33c2edd] - benchmark: fix calibrate-n option handling (Luan Muniz) #641466c107c35ad] - buffer: use Clamp conversion in Blob slice (Donghoon Kang) #647395fda0958bd] - buffer: validate copyArrayBuffer offsets against buffer length (Ilia Alshanetsky) #639045e433fdee6] - build: run perfetto build and test on GHA (Chengzhong Wu) #6472111680ab225] - build: fix v8_use_perfetto source scraping (Chengzhong Wu) #64721ab5f076d7f] - build: bump rustc requirement to >=1.86 (Renegade334) #64543df608e061f] - (SEMVER-MINOR) build: perfetto-sdk (Chengzhong Wu) #6456578538f1207] - build,tools: fix shared library cross-compile (Kirill Saied) #6396382712652cb] - (SEMVER-MINOR) crypto: support loading private keys through STORE loaders (Filip Skokan) #6394959f0682f7f] - crypto: preserve OpenSSL errors from KDF failures (Filip Skokan) #647760a23c1a8bc] - crypto: fix Argon2 bypassing FIPS mode (Filip Skokan) #64776b3aec47d09] - crypto: update root certificates to NSS 3.125 (Node.js GitHub Bot) #6474631f8c91e6e] - crypto: clarify missing cipher error (Filip Skokan) #64852efa22e71ff] - crypto: reuse X509 issuer result (Filip Skokan) #64852ac954d24ef] - crypto: validate key generation options (Filip Skokan) #64852a8a4e6669d] - crypto: fix Argon2 validation errors (Filip Skokan) #648520264a04aff] - crypto: handle XOF output allocation failure (Filip Skokan) #648516bb4121ed1] - crypto: initialize KeyObjectData mutex eagerly (Filip Skokan) #648511516f7fc09] - crypto: handle DH operation failures (Filip Skokan) #6485112170c3753] - crypto: use user-facing error for output encoding changes (Archkon) #64692474f06d550] - debugger: preserve overlapping CDP request state (Trivikram Kamat) #6446795d27e2249] - deps: upgrade npm to 11.19.0 (npm team) #64883c03c9090d3] - deps: update ngtcp2 to 1.25.0 (Node.js GitHub Bot) #64944ebbb978b87] - deps: update nghttp3 to 1.18.0 (Node.js GitHub Bot) #649432c4bf7234d] - deps: update minimatch to 10.2.6 (Node.js GitHub Bot) #6494529006f6da6] - deps: update simdjson to 4.6.6 (Node.js GitHub Bot) #64942d97ba2cb6c] - deps: update acorn to 8.18.0 (Node.js GitHub Bot) #64941261d78d724] - deps: update googletest to 1b6f64d659944658a4c685b7bd9f04c1c3b8a39b (Node.js GitHub Bot) #649403133097be3] - deps: update nghttp2 to 1.70.0 (Node.js GitHub Bot) #64939ebcf3c95c9] - deps: update zlib to 1.3.2.1-motley-42c2f19 (Node.js GitHub Bot) #64744a22e4317c1] - deps: V8: backport 5177b10891e6 (avivkeller) #64631cd95d5c598] - deps: update ada to 4.0.0 (Node.js GitHub Bot) #6479070dedef942] - deps: update sqlite to 3.53.4 (Node.js GitHub Bot) #647457bc4c171f5] - deps: update Rust crates for V8 14.6.202.34-node.26 (Renegade334) #64543308c6b2ac3] - deps: V8: backport 7d9b7e03141d (Manish Goregaokar) #645438eeae28e88] - deps: V8: backport c4d06ba586f3 (liujiahui) #63731bbd6fc58c4] - diagnostics_channel: grow native channel storage (Stephen Belanger) #6449737a41c228b] - doc: fix grammar and punctuation in dgram documentation (Kamal Rawal) #64957a7625d5012] - doc: fix grammar and editorial issues in addons documentation (Kamal Rawal) #64952431fddf1c5] - doc: formalize fn/name as part of TestOptions API (Christopher Hiller) #64946a3951574dd] - doc: remove references toca/crlas per-context QuicSession options (René) #64769abce850aef] - doc: fix typo in maintaining-dependencies.md (greenhead) #648960a0549fcb9] - doc: add RafaelGSS as last security release stewards (Rafael Gonzaga) #648433da9d77f27] - doc: fix typos in documentation (greenhead) #64900aa7c363f6d] - doc: fix missing references in doc type map (Tim Perry) #6487225c86942ae] - doc: improve TestContext hook descriptions (Kamal Rawal) #64899d926ddc307] - doc: add missing float32/float64 FFI type names (Soul Lee) #64874f2a05ee3d1] - doc: document stream.isDestroyed() (YspritanHyzygy) #647895604e4e8e5] - doc: add contributing detail for git Signed-off-by trailer (Mike McCready) #64862fa6075f1ed] - doc: mark config-file as release candidate (Marco Ippolito) #6451624530c76bc] - doc: fix duplicated word in test snapshot docs (Kamal Rawal) #64837e27b4ad287] - doc: remove obsolete cctest node.gyp instructions (Soul Lee) #6481424c7eaf661] - doc: report proper return type on url.format (Brian Muenzenmeyer) #64806d35315b263] - doc: use ffi.suffix for library paths in examples (Junsoo Ha) #648054be571df69] - doc: document --permission-audit audit mode behavior (Adrián Estrada) #64791e48b917bf7] - doc: clarify tlsSocket.authorized on resumption (soreavis) #64584db95655c4a] - doc: stabilize --disable-warning (Jean Michelet) #64742a8367200be] - doc: add MDN links for explicit resource management in fs (lluisemper) #595571c09165c2e] - doc: mention constructor check in deepStrictEqual (Sumit Kumar Das) #6201029709324e0] - doc: update technical priorities (Jacob Smith) #64505522a28e648] - doc: deprecation add more codemod (Augustin Mauroy) #63175c40aaa6539] - doc: run license-builder (Node.js GitHub Bot) #63918e64152c641] - ffi: fix crash in refCallback and unrefCallback (Trivikram Kamat) #648819b5642cbbf] - ffi: reject fast calls after library close (Trivikram Kamat) #648607adc5a45ad] - ffi: validate fast 32-bit integer argument ranges (Trivikram Kamat) #646912c3b1f1e9d] - ffi: fix optimized buffer conversions (Trivikram Kamat) #64639b2762a1ffa] - ffi: preserve link register in ppc64 trampoline (Trivikram Kamat) #64792aa3f168b31] - ffi: preserve strings during reentrant calls (Trivikram Kamat) #64551ca60942f38] - ffi: preserve uint8 semantics for bool fast calls (Trivikram Kamat) #645270fb1d2bd65] - ffi: validate fast integer argument ranges (Trivikram Kamat) #646149209bf1bd2] - fs: key glob matcher cache by platform (Archkon) #645714de7938c5b] - http: fix writableFinished and 'finish' after write errors (Tim Perry) #64847daee5467c0] - http: avoid aborting IncomingMessage signal on normal close (Archkon) #64392d5cdc120c3] - http: guard invalid timeout values in checkConnections (Efe Karasakal) #645066879aa4aa8] - http: propagate highWaterMark to ClientRequest OutgoingMessage (trivenay) #6465372448a82f4] - http2: avoid copying the options in respond() (Matteo Collina) #64265f6692da576] - http2: avoid per-write closures in kWriteGeneric (Matteo Collina) #642653ed37153f8] - http2: reduce per-request allocations (Matteo Collina) #64265bce92debba] - Revert "http2: avoid per-write closures in kWriteGeneric" (Antoine du Hamel) #64663b5d5dd74a1] - Revert "http2: avoid copying the options in respond()" (Antoine du Hamel) #64663b95e5f9fd8] - lib: fix AbortSignal.any() observed-composite leak (Paul Bouchon) #6448122d8868e37] - lib: fix typo in comment in _http_client.js (agape1225) #64729c1e4f7365e] - (SEMVER-MINOR) lib: add perfetto support (Chengzhong Wu) #645656c2157522d] - loader: enforce path normalization before lookup (Maël Nison) #63917f14be4c42a] - meta: bump actions/stale from 10.3.0 to 11.0.0 (dependabot[bot]) #64935f13b57da0d] - meta: bump github/codeql-action/analyze from 4.36.2 to 4.37.3 (dependabot[bot]) #649343e5f5f3cca] - meta: bump github/codeql-action/autobuild from 4.36.2 to 4.37.3 (dependabot[bot]) #64933387211bcdb] - meta: bump actions/setup-python from 6.3.0 to 7.0.0 (dependabot[bot]) #64932e7738fa25d] - meta: bump github/codeql-action/init from 4.36.2 to 4.37.3 (dependabot[bot]) #64931cbceae1e4d] - meta: bump Mozilla-Actions/sccache-action from 0.0.10 to 0.0.11 (dependabot[bot]) #6493068ce6c71ab] - meta: bump cachix/install-nix-action from 31.10.6 to 31.11.0 (dependabot[bot]) #649299d7e7c21a3] - meta: bump github/codeql-action/upload-sarif from 4.36.2 to 4.37.3 (dependabot[bot]) #64927402c1eacb4] - meta: bump step-security/harden-runner from 2.19.4 to 2.20.0 (dependabot[bot]) #64926dba4d4b4c7] - meta: bump ossf/scorecard-action from 2.4.3 to 2.4.4 (dependabot[bot]) #649259077d72ffe] - meta: remove node_crates .gitignore (René) #647798e03c54347] - meta: add @nodejs/url as codeowner for node_url_pattern.* (Efe Karasakal) #6473711c2f9c642] - (SEMVER-MINOR) module: implement Symbol.dispose in ModuleHooks (Remco Haszing) #63928b6e7935aca] - (SEMVER-MINOR) net: add experimental net/promises API (Ethan Arrowood) #63965fffd8a76d0] - net: support TCP handle transfer on Windows (Matteo Collina) #64460fe9e0dbdc2] - net: support AF_UNIX paths in net.BoundSocket (Guy Bedford) #64399240a86dac0] - permission: add unique warning codes (David Evans) #64414e970e6735b] - permission: support v8.setHeapSnapshotNearHeapLimit (Ilyas Shabi) #648080ba091165c] - quic: fix stop sending behaviour & callback (Tim Perry) #64710117ac84542] - quic: fix coverage comment typo (Jungwon Sohn) #64486960cc2c644] - quic: fix segfault after fragmented client hello (Tim Perry) #64720dcc348af97] - quic: serialize stream reset code as string (한만욱) #64577c25b8e3331] - readline: reduce createInterface overhead (Matteo Collina) #645859d536c3eb8] - sqlite: invalidate sessions when closing database (Trivikram Kamat) #64783d31113ef25] - sqlite: check database state before calling SQLite (Trivikram Kamat) #64812bb86521a42] - sqlite: fix crash when a session outlives its database (Mohamed Sayed) #63797870f4997e7] - sqlite: fix use-after-free in Exec() and ApplyChangeset() (Matteo Collina) #64535863ce4a78b] - src: fix perfetto build on GetTraceFilePath (Chengzhong Wu) #64721c299d2eef3] - src: implement MemoryRetainer protocol for ByteSource (Filip Skokan) #646608725e56928] - src: fix crash when writing odd-length hex string via Writev (RajeshKumar11) #63658e018f9a4a1] - (SEMVER-MINOR) src: add perfetto trace agent (Chengzhong Wu) #645650611d443ab] - (SEMVER-MINOR) src: rename legacy trace event headers (Chengzhong Wu) #645652897cc1d93] - (SEMVER-MINOR) src: fix trace macro compatibility (Chengzhong Wu) #64565d4d7172e10] - src: avoid using ToLocalChecked in crypto_hash (James M Snell) #6466853b7d48b47] - src: fix libuv assertion on windows (liuxingbaoyu) #61999bc041dd2bd] - src,test: disable trace events tests when perfetto is enabled (Chengzhong Wu) #6472176baf80f81] - stream: cut per-chunk allocations in pipeTo (Matteo Collina) #64890452c544489] - stream: preserve push signal abort reason (Trivikram Kamat) #64798f98a0f9c5b] - stream: skip zero-byte broadcast writes (Trivikram Kamat) #64772420c3efcab] - stream: honor AbortSignal in Writer.end() (Trivikram Kamat) #647271e182d147f] - stream: use validateString for consumer encoding (Jungwon Sohn) #64754e024712134] - stream: use the ring buffer for pending BYOB pull-into descriptors (Matteo Collina) #64818fe06bf56dc] - stream: fix uncatchable error closing half-open Duplex.toWeb() writable (Mohamed Sayed) #641616f57dbc1da] - test: unflake debugger and REPL tests (Matteo Collina) #64718582e88a68c] - test: ensure assertions are reached on all tests (Antoine du Hamel) #64716ba1ef78e48] - test: reuse ffi.suffix instead of reimplementing it (Seongeun Lee) #64840e700a2e72c] - test: remove test-repl-user-error-handler from flaky (avivkeller) #64631fafac6e29c] - test: update WPT for url to 4832db4761 (Node.js GitHub Bot) #6482937dee176c1] - test: update WPT for url to b63305b743 (Node.js GitHub Bot) #647904cb72eecb3] - test: cover worker throwing primitive values (varshitha) #64365796acc8920] - test: mark test-repl-user-error-handler as flaky (Aviv Keller) #64612dccee04558] - (SEMVER-MINOR) test_runner: add support for --test-coverage-include-all (avivkeller) #6483004bba8d6c0] - test_runner: wait for filtered suite build (semimikoh) #6420870d11241a3] - test_runner: convert to uint during deserialization (Aviv Keller) #647064bc2ed847e] - tls: fix SNICallback certificate selection (Matteo Collina) #647003f53f86e86] - tools: bump the eslint group in /tools/eslint with 4 updates (dependabot[bot]) #64928339d5a1c9e] - tools: bump brace-expansion from 5.0.7 to 5.0.9 in /tools/eslint (dependabot[bot]) #6490465ef34b75c] - tools: use 'readonly' for EventSource global (Honey Tyagi) #6478792f5aed83b] - typings: add heap_utils internalBinding types (Donghoon Kang) #648163bc0ee0492] - typings: remove isDataView from types binding (Archkon) #64738236d7ca965] - url: create URLPattern result properties in WebIDL order (Archkon) #647333def577ab4] - v8: report minor mark-sweep in GCProfiler (Archkon) #64688de2ebff845] - vfs: speed up recursive readdir test setup (Trivikram Kamat) #648134345185496] - vfs: make lchown update symlink metadata (Trivikram Kamat) #64573f6e39ed872] - wasm: register missing SetURL function (Archkon) #64679f322870bd1] - zlib: validate pledgedSrcSize as a safe integer (Archkon) #6460444042c20d4] - zlib: accept ArrayBuffer dictionary in Zstd (Ryuhei Shima) #64599