Skip to content

chore(remark-lint): improve for node core#9016

Open
avivkeller wants to merge 2 commits into
mainfrom
remark-lint-changes
Open

chore(remark-lint): improve for node core#9016
avivkeller wants to merge 2 commits into
mainfrom
remark-lint-changes

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 21, 2026

Copy link
Copy Markdown
Member

Improves the remark-lint package by:

  • Fixing an issue with type validation where it would include comments, code blocks, etc
  • Adding link validation, as mentioned by @aduh95

@avivkeller
avivkeller requested review from a team as code owners July 21, 2026 03:35
Copilot AI review requested due to automatic review settings July 21, 2026 03:35
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 21, 2026 3:39am

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Enabling link validation in the default preset may introduce new lint failures across docs; the type-reference change is a false-positive fix with low regression risk.

Overview
Bumps @node-core/remark-lint to 1.4.0 and wires remark-validate-links into the default preset so markdown lint can flag broken local heading links (e.g. missing-heading).

The node-core:invalid-type-reference rule no longer scans every AST node by raw value; it only runs on text and html nodes that match the type-reference pattern, so {…} in HTML comments, inline code, fenced blocks, and raw HTML are ignored. Tests cover that case, and the rule test helper now returns the parsed tree for optional assertions.

Reviewed by Cursor Bugbot for commit ee06ec6. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.83%. Comparing base (7dac7d8) to head (ee06ec6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9016      +/-   ##
==========================================
+ Coverage   74.57%   74.83%   +0.26%     
==========================================
  Files         100      101       +1     
  Lines        8803     8891      +88     
  Branches      324      329       +5     
==========================================
+ Hits         6565     6654      +89     
+ Misses       2234     2233       -1     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee06ec6. Configure here.

Comment thread packages/remark-lint/src/index.mjs
@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 10.64 MB
New Total First Load JS 10.64 MB
Delta 0 B (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants