fix(codemod utils): handle non-node imports correctly#505
Open
AugustinMauroy wants to merge 4 commits into
Open
fix(codemod utils): handle non-node imports correctly#505AugustinMauroy wants to merge 4 commits into
AugustinMauroy wants to merge 4 commits into
Conversation
cause: .slip on undefined dued to catching imported type
cause: import-statement was catching `vitest` dude to `vite`
AugustinMauroy
added
the
awaiting reviewer
AugustinMauroy
changed the title
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
Member
There was a problem hiding this comment.
Thanks!
I think we should have some tests with the node: prefix and without it.
There are some seemingly unrelated tests added here. Are they actually related? If not, they should go in their own PR.
Member
Author
that was to fetch ast and search for type node but it's an unnamed node ... |
brunocroh
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.