Upgrade Unity versions used to run tests on CI (Unity 6.5/ test-framework v1.7.0)#42
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> EOF )
87fe0ac to
5d9130b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3946065 to
5d9130b
Compare
Code Metrics Report
Details | | master (0558116) | #42 (de502e2) | +/- |
|---------------------|------------------|---------------|-------|
- | Coverage | 40.3% | 39.3% | -1.1% |
| Files | 25 | 25 | 0 |
| Lines | 478 | 478 | 0 |
- | Covered | 193 | 188 | -5 |
+ | Code to Test Ratio | 1:4.0 | 1:4.0 | +0.0 |
| Code | 1256 | 1255 | -1 |
+ | Test | 5048 | 5057 | +9 |
- | Test Execution Time | 5m20s | 5m47s | +27s |Code coverage of files in pull request scope (9.4% → 0.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6000.5.1f1) to the CI test matrixIs.BinarySerializableexample with#if !ENABLE_UTF_1_7Changes
CI
6000.5.1f1to theunityVersionmatrixPackage upgrades
com.cysharp.unitask: 2.5.x → 2.5.11com.nowsprinting.create-script-folders-with-tests: 1.3.x → 1.4.0com.nowsprinting.test-helper: 1.4.x → 1.5.0com.nowsprinting.test-helper.ui: 1.2.x → 1.3.0Deprecated API fixes (Unity 6.4+,
CS0618as error)CS0618(obsolete) as a compile error (Default.globalconfig)FindObjectOfType/FindObjectsOfTypewith#if UNITY_2022_3_OR_NEWERguardsFindFirstObjectByTypewithFindAnyObjectByType(obsolete in Unity 6.4)Unity 6.5 / test-framework 1.7 compatibility
UnityTestFrameworkVersionChecktest cases to cover Unity 6.5 (6000.5.0f1+)ENABLE_UTF_1_7toAPIExamples.Tests.asmdefversionDefinesBinarySerializableConstraintexample with#if !ENABLE_UTF_1_7Misc
.claude/)Background: Why
Is.BinarySerializablebroke on Unity 6.5Unity 6.5 ships
com.unity.test-framework1.7.0, which bumpscom.unity.ext.nunitfrom 2.0.5 to 2.1.0. Despite the assembly version remaining
3.5.0.0, Unity's customNUnit 3.5 fork in 2.1.0 removes
BinarySerializableConstraint— becauseBinaryFormatteris deprecated in .NET.XmlSerializableConstraintis still present.The fix adds an
ENABLE_UTF_1_7version define (matching the repo's existingENABLE_UTF_1_5/ENABLE_UTF_1_6convention) and wraps theBinarySerializableSampleclass and its test in#if !ENABLE_UTF_1_7.