feat(config): add --ignore-proxy flag#9752
Open
hemanth wants to merge 2 commits into
Open
Conversation
When set, ignores proxy and https-proxy settings, allowing direct connections without going through any configured proxy. Closes: npm/rfcs#380
Add unit tests verifying that the ignore-proxy config correctly nullifies both proxy and https-proxy flatten values when set to true, and preserves them when false. Regenerate all affected snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add an
ignore-proxyboolean config that, when set totrue, nullifiesproxyandhttps-proxysettings.Why?
Closes #380. Users with a proxy configured globally (e.g., corporate
.npmrcor environment variables) currently have no simple way to bypass it for specific operations. They must manually unset bothproxyandhttps-proxy, which is error-prone and inconvenient.Approach
ignore-proxyDefinition (default: false,type: Boolean) in the config definitions.ignore-proxyits ownflatten, the existingproxyandhttps-proxyflatten functions were modified to checkobj["ignore-proxy"]and returnnullwhen it is truthy. This keeps the nullification co-located with the settings it affects.Verification
workspaces/config/test/definitions/definitions.js:https-proxyflattens tonullwhenignore-proxyistruehttps-proxypasses through whenignore-proxyisfalseproxyflattens tonullwhenignore-proxyistrueproxypasses through whenignore-proxyisfalsedocs,config list,type-description).