Skip to content

fix(arborist): strip path separators from version in store key #9758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ubeddulla wants to merge 1 commit into
base: latest
Choose a base branch
from
+5 −1
Open

fix(arborist): strip path separators from version in store key #9758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion workspaces/arborist/lib/arborist/isolated-reifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ const getKey = (startNode) => {
.replace(/=+$/m, '')
// a patched entry gets a distinct, identifiable side-store key so unpatched consumers keep sharing the original
const patchSuffix = startNode.patched ? '+patch' : ''
return `${startNode.packageName}@${startNode.version}-${hash}${patchSuffix}`
// version comes straight from an untrusted package.json and this key becomes a
// path segment below (join('node_modules', '.store', key, ...)); strip separators
// so a crafted version can't traverse out of the store, matching packageName
const version = String(startNode.version).replace(/[/\\]/g, '_')
return `${startNode.packageName}@${version}-${hash}${patchSuffix}`
}

module.exports = cls => class IsolatedReifier extends cls {
Expand Down
Loading