fix(arborist): apply allowScripts gate to scripts pacote runs at extract#9777
Open
ubeddulla wants to merge 1 commit into
Open
fix(arborist): apply allowScripts gate to scripts pacote runs at extract#9777ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pacote runs a git or directory dep's
preparescript while extracting it, which happens before the node ever reaches the rebuild queues where the allowScripts gate is applied. WithallowScripts: {}a git dependency's prepare script still runs on install, and npm prints its "install scripts blocked because they are not covered by allowScripts" warning naming that same package while the script is running, so the policy reads as enforced when it is not. Both of pacote's fetchers already honorignoreScripts, so deriving it from the same check rebuild uses closes this at the twopacote.extractcall sites (reify, and the bundle-dep crack-open under--package-lock-only); approved packages and--dangerously-allow-all-scriptsstill run prepare exactly as before.