node: skip TTL=1 request signatures over inter-node mTLS - #4100
Draft
End-rey wants to merge 2 commits into
Draft
Conversation
Member
|
Yes, SDK should be updated to do/not do this based on client status. |
End-rey
force-pushed
the
internode-client-cert
branch
2 times, most recently
from
July 31, 2026 13:25
294c5f3 to
d15b80b
Compare
End-rey
force-pushed
the
mtls-internode-dont-sign-requests
branch
from
July 31, 2026 13:28
fe8ddc8 to
6526e43
Compare
End-rey
force-pushed
the
internode-client-cert
branch
2 times, most recently
from
August 5, 2026 14:06
1d9c14f to
2113b4b
Compare
Require and verify client certificates from inter-node TLS peers against the network map. Track connections that completed mutual TLS and omit request signatures for forwarded TTL=1 HEAD, GET, RANGE, PUT, and SEARCH requests over them. Keep signing when TLS is unavailable, mutual authentication is incomplete, or the request TTL is not one. Closes #4089. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use the SDK local request signing status to omit signatures from TTL=1 object requests sent over a mutually authenticated connection. Keep signatures for plain connections, TLS connections without mutual authentication, and requests with other TTL values. Update SDK to the version providing this API. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
mtls-internode-dont-sign-requests
branch
from
August 6, 2026 15:47
6526e43 to
efae3b6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4100 +/- ##
=======================================
Coverage 27.27% 27.28%
=======================================
Files 678 679 +1
Lines 46282 46367 +85
=======================================
+ Hits 12624 12649 +25
- Misses 32443 32497 +54
- Partials 1215 1221 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would it make sense to add an SDK option for unsigned requests?
Some inter-node TTL=1 paths still use SDK
ObjectHead/ObjectGetInit/ObjectRangeInit/ObjectPutInit, which always sign requests. An opt-in parameter such asDisableRequestSigningcould let the node skip signatures after it has confirmed mTLS, while keeping the SDK default safe.