Ignore PUT chunk signatures - #4105
Draft
cthulhu-rider wants to merge 1 commit into
Draft
Conversation
If object is sealed, payload can be verified using in-header checksum. Otherwise, chunk can be changed and signed with any key. In total, chunk verification headers only waste resources without any real value. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4105 +/- ##
==========================================
- Coverage 27.07% 27.07% -0.01%
==========================================
Files 676 676
Lines 46110 46110
==========================================
- Hits 12484 12483 -1
- Misses 32428 32429 +1
Partials 1198 1198 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
requested changes
Jul 29, 2026
Member
|
Also, PUT performance is a different story, we have a lot to optimize there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.