Optimize local ranged GET - #4115
Open
cthulhu-rider wants to merge 2 commits into
Open
Conversation
cthulhu-rider
force-pushed
the
ec-get-range-buffers-continue
branch
3 times, most recently
from
August 5, 2026 07:53
2659bf4 to
3988aef
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4115 +/- ##
==========================================
- Coverage 27.27% 27.25% -0.02%
==========================================
Files 678 678
Lines 46282 46300 +18
==========================================
- Hits 12624 12621 -3
- Misses 32443 32466 +23
+ Partials 1215 1213 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
ec-get-range-buffers-continue
branch
from
August 5, 2026 08:10
3988aef to
98f9298
Compare
cthulhu-rider
marked this pull request as ready for review
August 5, 2026 08:25
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
August 5, 2026 08:25
roman-khimov
approved these changes
Aug 6, 2026
| ReadHeader(oid.Address, []byte) (int, error) | ||
| ReadObject(oid.Address, []byte) (int, io.ReadCloser, error) | ||
| ReadPayloadRange(oid.Address, uint64, uint64, []byte, func([]byte) error) (io.ReadCloser, error) | ||
| ReadObjectParts(buf []byte, addr oid.Address, rng PayloadRange, interceptHeaderBinaryFn func([]byte) error) (int, io.ReadCloser, error) |
Member
There was a problem hiding this comment.
Can we not add another method into Storage? Likely GetRangeStream can be extended a bit to do the same thing.
Contributor
Author
There was a problem hiding this comment.
existing interfaces do not fit well, so I decided to not touch their callers. Once the optimization is extended to all cases, the number of methods can be reduced
Member
|
Conflicts. |
cthulhu-rider
force-pushed
the
ec-get-range-buffers-continue
branch
from
August 6, 2026 17:03
98f9298 to
516ffaa
Compare
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Closes #4108. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
ec-get-range-buffers-continue
branch
from
August 6, 2026 17:06
516ffaa to
efe7035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.