Optimize buffering of forwarded SEARCH requests - #4116
Open
cthulhu-rider wants to merge 1 commit into
Open
Conversation
cthulhu-rider
force-pushed
the
search-buffers
branch
from
August 5, 2026 15:28
4347a87 to
1695f41
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4116 +/- ##
==========================================
- Coverage 27.27% 27.21% -0.07%
==========================================
Files 678 678
Lines 46282 46352 +70
==========================================
- Hits 12624 12615 -9
- Misses 32443 32519 +76
- Partials 1215 1218 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
marked this pull request as ready for review
August 5, 2026 15:43
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
August 5, 2026 15:43
Server-side part of nspcc-dev/neofs-sdk-go@c4dda73. Additionally de-duplicates the request encoding for sending to multiple nodes. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
search-buffers
branch
from
August 6, 2026 17:08
1695f41 to
5d595c6
Compare
roman-khimov
reviewed
Aug 6, 2026
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
We need to share this code with SDK, it's unmaintainable otherwise.
|
|
||
| func (s *Server) writeLocalSearchObjectsRequest(buf []byte, bodyLen int, body *protoobject.SearchV2Request_Body, metaHdrLen int) (int, error) { | ||
| // TODO: can be calculated once and reused | ||
| originSig, err := neofsecdsa.Signer(s.signer).Sign(nil) |
Contributor
Author
this is planned to be done in #4005 |
Member
|
Let's solve #4005 first then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.