Better compatibility with Dolby vision#402
Conversation
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
|
@XChikuX can you resolve conflicts? |
| // Some inputs (e.g. iPhone .MOV files) report a "video/dolby-vision" MIME | ||
| // type that many devices cannot decode. Remap to a decodable base-layer | ||
| // codec, or fail with a clear error, before creating the decoder (#398). | ||
| ensureDecodableVideoFormat(inputFormat) |
There was a problem hiding this comment.
ios change looks good to me
one android concern before merge: when we remap Dolby Vision from video/dolby-vision to video/hevc or video/avc, we only update KEY_MIME
but the same MediaFormat may still contain Dolby Vision KEY_PROFILE and KEY_LEVEL values. that can cause MediaCodec.configure() to fail because the mime is now hevc/avc but the profile is still Dolby Vision
can we also clear KEY_PROFILE and KEY_LEVEL after changing the mime, and test with one real iphone hdr .MOV on android
There was a problem hiding this comment.
Will need sometime to get to this.. You have full edit permissions if you'd like to take the lead.
There was a problem hiding this comment.
i have to setup this whole project in my local currently my focus is on building some proudct in agentic ai, can you fix it, i will test it by automation and merge it
|
relased in |
I also worked on this with copilot. Changes are worth looking over..