Skip to content

fix(google-maps): deprecate heatmap component#809

Merged
harlan-zw merged 1 commit into
mainfrom
fix/google-maps-heatmap-deprecation
Jun 2, 2026
Merged

fix(google-maps): deprecate heatmap component#809
harlan-zw merged 1 commit into
mainfrom
fix/google-maps-heatmap-deprecation

Conversation

@harlan-zw
Copy link
Copy Markdown
Collaborator

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

@types/google.maps v3.65 stripped HeatmapLayer and HeatmapLayerOptions down to an empty stub as part of Google's deprecation (deprecated May 2025, runtime feature removed May 2026), which broke nuxt typecheck in ScriptGoogleMapsHeatmapLayer.vue (missing HeatmapLayerOptions, setMap, setOptions).

This types the heatmap layer surface locally so the component compiles again, and flags it as deprecated: a dev-only console.warn on use plus an @deprecated JSDoc on the options prop, both pointing to deck.gl HeatmapLayer as the alternative. The component still works at runtime for anyone pinned to an older Maps version.

@types/google.maps v3.65 removed HeatmapLayer/HeatmapLayerOptions (Google's deprecation, runtime gone May 2026), breaking typecheck. Type the layer surface locally so it compiles, and flag the component as deprecated via a dev warning and @deprecated JSDoc pointing to deck.gl.
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scripts-playground Ready Ready Preview, Comment Jun 2, 2026 3:39am

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 2, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts@809

commit: 698a8b1

@harlan-zw harlan-zw changed the title fix(google-maps): repair heatmap layer types and deprecate component fix(google-maps): deprecate heatmap component Jun 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

ScriptGoogleMapsHeatmapLayer adds a deprecation notice warning users that Google Maps HeatmapLayer is being removed from the Maps JS API in v3.65. To future-proof against type removal from @types/google.maps, the component defines local HeatmapLayerOptions and HeatmapLayer TypeScript interfaces and updates the implementation to use these local types instead of external ones. The runtime behavior remains unchanged: the component imports the visualization library, creates a heatmap layer, sets the map, and applies options via setOptions using existing deep-watch and cleanup logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the context (v3.65 type removals), the problem (broken typecheck), and the solution (local type definitions plus deprecation notice).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: deprecating the heatmap component in Google Maps integration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/google-maps-heatmap-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@harlan-zw harlan-zw merged commit c92ac39 into main Jun 2, 2026
19 checks passed
@harlan-zw harlan-zw deleted the fix/google-maps-heatmap-deprecation branch June 2, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant