fix(proxy): hash upstream cache keys#835
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughCache key generation for binary, JSON/text, and Instagram embed upstream requests now hashes normalized URLs, options, headers, or composite key parts before Nitro storage. Binary keys also vary on Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
No linked issue.
❓ Type of change
📚 Description
Nitro writes custom
defineCachedFunctionkeys directly into unstorage paths. The embed and proxy handlers passed full upstream URLs, so reserved URL characters could produce invalid keys on stricter storage drivers.Hash normalized JSON, binary, and Instagram embed cache keys before storage. Binary keys now also vary on
ignoreResponseError.