fix: preserve function tool schema constraints - #718
Open
weivwang wants to merge 1 commit into
Open
Conversation
weivwang
marked this pull request as ready for review
August 13, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve JSON Schema constraints generated for Python function parameters when converting callables into Ollama tools.
convert_function_to_toolcurrently replaces each property schema with onlytypeanddescription. That drops constraints such as arrayitemsandLiteralenumvalues, so models are not told what array elements or allowed values a tool accepts.This change keeps the generated property fields, removes the superseded
anyOf, and then applies the existing normalized type and docstring description behavior.Testing
NO_PROXY=localhost,127.0.0.1 no_proxy=localhost,127.0.0.1 uv run --with pytest --with pytest-anyio --with pytest-httpserver pytest ollama tests -q(103 passed)uv run --with ruff ruff check ollama testsuv run --with ruff ruff format --check ollama testsgit diff --check