Skip to content

fix: write CA certs to XDG_RUNTIME_DIR for per-user isolation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: write CA certs to XDG_RUNTIME_DIR for per-user isolation #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/container/ca.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,17 @@ const SYSTEM_CA_PATHS = [
"/etc/pki/tls/certs/ca-bundle.crt", // RHEL / CentOS / Fedora
];

/** Per-user cache dir. XDG_RUNTIME_DIR is per-user on Linux; tmpdir() fallback covers macOS/Windows. */
function caCacheDir(): string {
return process.env.XDG_RUNTIME_DIR ?? tmpdir();
}

/**
* Write the proxy CA certificate PEM to a temp file on the host.
* Write the proxy CA certificate PEM to a per-user file on the host.
* Returns the path to the written file.
*/
export function writeCaCertificate(caCertificate: string): string {
const outPath = join(tmpdir(), "onecli-proxy-ca.pem");
const outPath = join(caCacheDir(), "onecli-proxy-ca.pem");
writeFileSync(outPath, caCertificate);
return outPath;
}
Expand All @@ -28,7 +33,7 @@ export function buildCombinedCaBundle(caCertificate: string): string | null {
try {
const sysCa = readFileSync(sysPath, "utf8");
const combined = sysCa.trimEnd() + "\n" + caCertificate.trimEnd() + "\n";
const outPath = join(tmpdir(), "onecli-combined-ca.pem");
const outPath = join(caCacheDir(), "onecli-combined-ca.pem");
writeFileSync(outPath, combined);
return outPath;
} catch {
Expand Down