Do not attempt to enumerate or normalize entries from carrier#8474
Open
jack-berg wants to merge 2 commits into
Open
Do not attempt to enumerate or normalize entries from carrier#8474jack-berg wants to merge 2 commits into
jack-berg wants to merge 2 commits into
Conversation
Member
|
This is correct. Just the tests need to be updated 😉 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8474 +/- ##
=========================================
Coverage 91.04% 91.04%
- Complexity 7822 7828 +6
=========================================
Files 893 893
Lines 23721 23727 +6
Branches 2364 2365 +1
=========================================
+ Hits 21596 21602 +6
+ Misses 1407 1406 -1
- Partials 718 719 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaydeluca
approved these changes
Jun 11, 2026
Comment on lines
+69
to
+78
| /** | ||
| * Determine if a key is a valid normalized environment variable name. | ||
| * | ||
| * <ul> | ||
| * <li>ASCII letters are converted to uppercase | ||
| * <li>Any character that is not an ASCII letter, digit, or underscore is replaced with an | ||
| * underscore (including {@code .}, {@code -}, whitespace, and control characters) | ||
| * <li>Does not start with a digit | ||
| * </ul> | ||
| */ |
Member
There was a problem hiding this comment.
I think this could be reworded to sound a bit more like a predicate
Suggested change
| /** | |
| * Determine if a key is a valid normalized environment variable name. | |
| * | |
| * <ul> | |
| * <li>ASCII letters are converted to uppercase | |
| * <li>Any character that is not an ASCII letter, digit, or underscore is replaced with an | |
| * underscore (including {@code .}, {@code -}, whitespace, and control characters) | |
| * <li>Does not start with a digit | |
| * </ul> | |
| */ | |
| /** | |
| * Determine if a key is a valid normalized environment variable name. Returns {@code true} if | |
| * {@code key} is non-empty, contains only uppercase ASCII letters, digits, and underscores, and | |
| * does not start with a digit. | |
| */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-telemetry/opentelemetry-specification#5144
cc @pellared - I think this is the intent of the spec PR