Remove duplicate session header update in OTLP HTTP exporters#5442
Open
Eason09053360 wants to merge 2 commits into
Open
Remove duplicate session header update in OTLP HTTP exporters#5442Eason09053360 wants to merge 2 commits into
Eason09053360 wants to merge 2 commits into
Conversation
The user headers were applied both before and after the default OTLP headers. The first update is fully overwritten by the later ones, so it is dead code; keeping it also invites accidentally reverting open-telemetry#4634, which deliberately applies user headers after the defaults so users can override them.
Contributor
|
This will be addressed once #5389 is merged. Putting this on hold for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All three OTLP HTTP exporters (span, metric, log) call
self._session.headers.update(self._headers)twice — once before the default_OTLP_HTTP_HEADERSand once after. #4634 deliberately moved the user-header update after the defaults so users can override them, but a later merge accidentally reintroduced the earlier call.The first call is fully overwritten by the subsequent updates, so it is dead code — and it invites a maintainer to remove the wrong line and silently revert #4634. This PR removes the earlier call in all three exporters. No behavior change.
Type of change
How Has This Been Tested?
opentelemetry-exporter-otlp-proto-httptest suite passes (59 tests), including the existing tests covering user headers overriding defaults.Does This PR Require a Contrib Repo Change?
Checklist: